Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PARI databases out of PARI package #15765

Closed
jdemeyer opened this issue Jan 30, 2014 · 16 comments
Closed

Move PARI databases out of PARI package #15765

jdemeyer opened this issue Jan 30, 2014 · 16 comments

Comments

@jdemeyer
Copy link
Contributor

The PARI package in Sage contains two databases (galdata and seadata-small). These should be separated and the packaging simplified.

Upstream (all these are simply repacked/renamed upstream tarballs):

CC: @jpflori @pjbruin

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: u/jdemeyer/ticket/15765 @ 1678b89

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/15765

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 1, 2014

Branch: u/jdemeyer/ticket/15765

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 1, 2014

Commit: ad63daf

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 1, 2014

New commits:

ad63dafMove PARI databases out of PARI package

@pjbruin
Copy link
Contributor

pjbruin commented Feb 2, 2014

comment:7

Nice restructuring, builds without problems, passes all tests.

@pjbruin
Copy link
Contributor

pjbruin commented Feb 2, 2014

Reviewer: Peter Bruin

@vbraun
Copy link
Member

vbraun commented Feb 2, 2014

comment:8

We already have a pari-2.5.5.tar.bz2 tarball. Since it is checksummed we can't replace it without breaking other builds. This shoud be done in conjuction with the next Pari update.

@vbraun vbraun removed this from the sage-6.2 milestone Feb 2, 2014
@vbraun vbraun added the pending label Feb 2, 2014
@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 2, 2014

comment:10

Since it will simplify the next upgrade, why not simply rename the tarball to something else? Can we call it pari-2.5.5b.tar.bz2 or something?

@vbraun
Copy link
Member

vbraun commented Feb 2, 2014

comment:11

That would work, too. But you can simplify the next upgrade just as well by starting with this branch.

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 2, 2014

comment:12

Replying to @vbraun:

That would work, too. But you can simplify the next upgrade just as well by starting with this branch.

But less so, since the probability of merge conflicts (I just resolved one) increases the longer that this branch does not get merged. And other people who want to work on PARI might not know about this ticket.

@jdemeyer

This comment has been minimized.

@jdemeyer jdemeyer added this to the sage-6.2 milestone Feb 2, 2014
@jdemeyer jdemeyer removed the pending label Feb 2, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

1678b89Merge remote-tracking branch 'origin/develop' into ticket/15765

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2014

Changed commit from ad63daf to 1678b89

@pjbruin
Copy link
Contributor

pjbruin commented Feb 3, 2014

comment:16

I did notice that the new pari-2.5.5.tar.bz2 had the same name but a different checksum, but didn't run into problems because I downloaded the new one by hand before checking out this branch. Should have tried harder to play the unsuspecting user... 8-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants