Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (symbolic) Struve functions #16221

Closed
kcrisman opened this issue Apr 23, 2014 · 31 comments
Closed

Add (symbolic) Struve functions #16221

kcrisman opened this issue Apr 23, 2014 · 31 comments

Comments

@kcrisman
Copy link
Member

Apparently Maxima has this.

struve_h (v,z)                 Struve H function
struve_l (v,z)                 Struve L function

See #15024 and the symbolic wiki on Trac for more detail.

Component: symbolics

Keywords: special, holonomic

Author: Ralf Stephan

Branch/Commit: cf92ce3

Reviewer: Karl-Dieter Crisman, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/16221

@kcrisman kcrisman added this to the sage-6.2 milestone Apr 23, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@rwst
Copy link
Contributor

rwst commented Aug 7, 2014

@rwst
Copy link
Contributor

rwst commented Aug 7, 2014

Author: Ralf Stephan

@rwst
Copy link
Contributor

rwst commented Aug 7, 2014

Changed keywords from none to special, holonomic

@rwst
Copy link
Contributor

rwst commented Aug 7, 2014

Commit: 03e076a

@rwst
Copy link
Contributor

rwst commented Aug 7, 2014

New commits:

03e076a16221: implement Struve H/L functions

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

a6a6310Merge branch 'develop' into t/16221/add__symbolic__struve_functions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2014

Changed commit from 03e076a to a6a6310

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

8b4b908Merge branch 'develop' into t/16221/add__symbolic__struve_functions
e7ad2ee16221: simplification due to improved BuiltinFunction; better doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2014

Changed commit from a6a6310 to e7ad2ee

@kcrisman
Copy link
Member Author

Reviewer: Karl-Dieter Crisman

@kcrisman
Copy link
Member Author

comment:7

Comments, putting 'needs info' just so the status is clear.

  • Think we should implement A&S 12.1.15 or 12.2.10?
  • This
sage: struve_L(i.n(),100)
1.07916123209824e42 + 4.90584803419713e22*I

doesn't seem to agree with W|A, though I don't know whether it should even be implemented.

  • W functions claims something that isn't in A&S but that certainly works with mpmath:
sage: struve_H(-2,0)
struve_H(-2, 0)
sage: struve_H(-3,0)
struve_H(-3, 0)
sage: struve_H(-3,0).n()
0.000000000000000
sage: struve_H(-2,0).n()
0.000000000000000
sage: struve_H(-7/2,0)
struve_H(-7/2, 0)
sage: struve_H(-7/2,0).n()
0.000000000000000
  • Maybe doctest at least a couple of the interfaces, at least with mpmath and Maxima? (I don't know if Maxima returns any of these when you plug in this particular DE, but if it did that would be perfect.)

Otherwise I think this is definitely ready to get in, and a useful addition!

@kcrisman
Copy link
Member Author

comment:8

One more thing - just like in #15024, probably there should be a little top-matter added, just for completeness.

@kcrisman
Copy link
Member Author

comment:9

(Interestingly, #18257 doesn't seem to afflict this one - maybe it didn't add as many functions as #15024.)

@rwst
Copy link
Contributor

rwst commented Jul 9, 2015

Changed branch from u/rws/add__symbolic__struve_functions to u/rws/16221

@rwst
Copy link
Contributor

rwst commented Jul 9, 2015

comment:12

That should do it. Could you please have a final glance?


New commits:

34c4d1e16221: Struve functions

@rwst
Copy link
Contributor

rwst commented Jul 9, 2015

Changed commit from e7ad2ee to 34c4d1e

@rwst rwst removed the s: needs work label Jul 9, 2015
@rwst rwst modified the milestones: sage-6.8, sage-7.1 Jan 22, 2016
@rwst
Copy link
Contributor

rwst commented Jan 22, 2016

Changed branch from u/rws/16221 to u/rws/16221-1

@fchapoton
Copy link
Contributor

comment:17

doc of _print_latex_ is not formatted correctly (twice)

REFERENCE blocks are not formatted correctly either.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 19, 2016

Changed commit from faf5fd5 to fbb6999

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 19, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

2980d87Merge branch 'u/rws/16221-1' of git://trac.sagemath.org/sage into tmp05
fbb699916221: fix doc refs and formatting

@fchapoton
Copy link
Contributor

comment:20

doc does not build: duplicate citation ASHandbook

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 20, 2016

Changed commit from fbb6999 to cf92ce3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 20, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

cf92ce316221: complete references

@rwst
Copy link
Contributor

rwst commented Mar 20, 2016

comment:22

The references in functions/ need some love in general.

@fchapoton
Copy link
Contributor

comment:23

ok, let it be

@fchapoton
Copy link
Contributor

Changed reviewer from Karl-Dieter Crisman to Karl-Dieter Crisman, Frédéric Chapoton

@rwst
Copy link
Contributor

rwst commented Mar 21, 2016

comment:24

Thanks for the review!

@fchapoton fchapoton modified the milestones: sage-7.1, sage-7.2 Mar 21, 2016
@vbraun
Copy link
Member

vbraun commented Mar 23, 2016

Changed branch from u/rws/16221-1 to cf92ce3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants