Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some exception handling #17076

Closed
jdemeyer opened this issue Sep 30, 2014 · 9 comments
Closed

Fix some exception handling #17076

jdemeyer opened this issue Sep 30, 2014 · 9 comments
Labels
p: minor / 4 t: enhancement
Milestone
sage-6.4

Comments

@jdemeyer
Copy link
Contributor

Change except: by except Exception: and fix some dubious uses of AssertionError.

Component: misc

Author: Jeroen Demeyer

Branch/Commit: fcba17f

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/17076
@jdemeyer jdemeyer added this to the sage-6.4 milestone Sep 30, 2014
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Fix some except clauses Fix some exception handling Oct 1, 2014
@jdemeyer
Copy link
Contributor Author

jdemeyer commented Oct 1, 2014

Branch: u/jdemeyer/ticket/17076

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Oct 1, 2014

Commit: df1e397

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Oct 1, 2014

New commits:

df1e397Fix some exception handling

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 7, 2014

Changed commit from df1e397 to fcba17f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 7, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

e23be2f17106: fix assert in sage.misc.c3_controlled doctest
20e8ec717106: fix indentation
fcba17fMerge remote-tracking branch 'origin/u/nthiery/fix_assert_in_sage_misc_c3_controlled' into ticket/17076

@fchapoton
Copy link
Contributor

comment:6

Looks good to me.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Oct 9, 2014

Changed branch from u/jdemeyer/ticket/17076 to fcba17f

@vbraun vbraun closed this as completed in f39cbe7 Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton