Replace R[x] by R['x'] in doctests

[jdemeyer]

This ticket is split off from #10483 and contains the trivial doctest fixes such that we can concentrate on the less trivial stuff in #10483.

Component: doctest coverage

Keywords: rings, variables, names

Author: Simon King, Ralf Stephan

Branch/Commit: 0e7a1c1

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/17407

[jdemeyer]

Branch: u/jdemeyer/ticket/17407

[jdemeyer]

Commit: 6429596

[jdemeyer]

New commits:

6429596

Trac #17407: replace R[x] by R['x'] in doctests

[jdemeyer]

Reviewer: Jeroen Demeyer

[rwst]

comment:4

That was too fast for me, I had a commit for #10483 in the works. I'll append the missing doctest fixes from #10483 here.

[rwst]

Changed branch from u/jdemeyer/ticket/17407 to public/17407

[rwst]

Changed commit from 6429596 to 1ffdb49

[rwst]

Changed keywords from none to rings, variables, names

[rwst]

New commits:

1ffdb49

17407: more doctest fixes

[jdemeyer]

Changed branch from public/17407 to u/jdemeyer/ticket/17407

[jdemeyer]

Changed commit from 1ffdb49 to b3289a8

[jdemeyer]

comment:8

Since I created this ticket specifically to treat only the easy trivial cases, I undid some of your changes (I'll add them to #10483 immediately).

Positive_review to the rest.

---

New commits:

b3289a8

Undo non-trivial changes

[rwst]

Changed branch from u/jdemeyer/ticket/17407 to u/rws/ticket/17407

[rwst]

New commits:

76c34e8

17407: even more dotest fixes, should be all

[rwst]

Changed commit from b3289a8 to 76c34e8

[jdemeyer]

comment:12

Don't review your own patches :-)

Can you please remove these changes:

sage: J = ZZ['x'].ideal(7,x)

and

sage: a = QQ[I]['x'](x)

[jdemeyer]

comment:13

For the french_book tests, it's probably better to keep the tests and simply add the deprecation message in #10483. So you should also remove those changes from this ticket.

[vbraun]

Changed branch from u/rws/ticket/17407 to 76c34e8

[vbraun]

Changed commit from 76c34e8 to none

[rwst]

comment:16

git ci tells me Your branch is based on 'trac/76c34e825a2381a7517b33c312ef9a06309866a8', but the upstream is gone.. So I guess Volker wants to encourage squashing of commits ;)

[jdemeyer]

comment:17

I have no idea what that means, are you unable to push your branch to trac?

[rwst]

Changed branch from 76c34e8 to public/17407

[rwst]

Commit: d4f68b7

[rwst]

comment:19

Replying to @jdemeyer:

I have no idea what that means, are you unable to push your branch to trac?

Volker confused me with taking back the 'fixed'.

---

New commits:

6429596	Trac #17407: replace R[x] by R['x'] in doctests
1ffdb49	17407: more doctest fixes
b3289a8	Undo non-trivial changes
76c34e8	17407: even more dotest fixes, should be all
d4f68b7	17407: more fixes

[jdemeyer]

comment:20

OK, now please do not make further changes to this branch.

[jdemeyer]

Changed branch from public/17407 to u/jdemeyer/ticket/17407

[jdemeyer]

comment:22

If you agree with this last commit, let's give this a definitive positive_review.

---

New commits:

0e7a1c1

Trivial doctest reformatting

[jdemeyer]

Changed commit from d4f68b7 to 0e7a1c1

[vbraun]

Changed branch from u/jdemeyer/ticket/17407 to 0e7a1c1