Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ambiguous incompatibility between coeffs() and coefficients() #17518

Closed
johnperry-math opened this issue Dec 17, 2014 · 12 comments
Closed

Comments

@johnperry-math
Copy link

This ticket adds a sparse parameter to the coefficients() method of the Polynomial class, and deprecates the use of coeffs() in a manner inconsistent with coefficients(), keeping with the discussion at https://groups.google.com/forum/#!topic/sage-devel/IHirUHTWnuA. See also trac #17438.

CC: @rwst

Component: commutative algebra

Keywords: polynomial coeffs coefficients

Author: John Perry

Branch/Commit: bb4a957

Reviewer: Ralf Stephan

Issue created by migration from https://trac.sagemath.org/ticket/17518

@johnperry-math
Copy link
Author

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 17, 2014

Commit: b48c35e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 17, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

b48c35epreliminary patch; main work done but a lot of doctests to go

@johnperry-math
Copy link
Author

comment:4

I'm still working on this; I wanted to push my commits for the time being. I'm pretty sure it only needs additional doctests, but if anyone wants to go ahead & look at the documentation & doctests of polynomial_element.pyx and polynomial_element_generic.py, it would be convenient for me to fix any problems with them tonight or tomorrow. :-)

PS: Sorry about removing the CC: earlier. It's nothing personal; I'm just clumsy.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

bb4a957completed modifications due to doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 18, 2014

Changed commit from b48c35e to bb4a957

@johnperry-math
Copy link
Author

comment:6

I've found all the doctests in need of modification that I can find, so, I think this is ready for review.

@rwst
Copy link
Contributor

rwst commented Dec 18, 2014

comment:7

Looks fine, doesn't clash with #17438, and passes make ptestlong. Please adapt the Author: field.

@rwst
Copy link
Contributor

rwst commented Dec 18, 2014

Reviewer: Ralf Stephan

@johnperry-math
Copy link
Author

comment:8

Thanks!

@johnperry-math
Copy link
Author

Changed author from john_perry to John Perry

@vbraun
Copy link
Member

vbraun commented Dec 21, 2014

Changed branch from u/john_perry/coeffs_confusion_polynomials to bb4a957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants