Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "match bug with echo" #17719

Closed
jdemeyer opened this issue Feb 3, 2015 · 10 comments
Closed

Fix "match bug with echo" #17719

jdemeyer opened this issue Feb 3, 2015 · 10 comments

Comments

@jdemeyer
Copy link
Contributor

jdemeyer commented Feb 3, 2015

#15631 added the following lines to src/sage/interfaces/expect.py:

                    if out == '':   # match bug with echo
                        out = line

It seems these were added to be compatible with an existing bug.

Instead, fix that bug!

CC: @vbraun

Component: interfaces

Author: Jeroen Demeyer

Branch/Commit: 4014b69

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/17719

@jdemeyer jdemeyer added this to the sage-6.5 milestone Feb 3, 2015
@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 3, 2015

Branch: u/jdemeyer/ticket/17719

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 3, 2015

Commit: 278e3a1

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 3, 2015

New commits:

278e3a1Fix match bug with echo

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Feb 3, 2015

Author: Jeroen Demeyer

@fchapoton
Copy link
Contributor

Changed branch from u/jdemeyer/ticket/17719 to public/ticket/17719

@fchapoton
Copy link
Contributor

comment:4

Looks good to me.

I have just made a small commit, adding another trac role, removing an unused variable and a duplicated import, all of that in the singular interface. If you agree, you can set this to positive review.


New commits:

ff34589Merge branch 'u/jdemeyer/ticket/17719' into 6.6.b0
4014b69trac #17719 a few details in doc of singular interface

@fchapoton
Copy link
Contributor

Changed commit from 278e3a1 to 4014b69

@jdemeyer
Copy link
Contributor Author

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:6

Please set to positive review, if you want

@vbraun
Copy link
Member

vbraun commented Feb 24, 2015

Changed branch from public/ticket/17719 to 4014b69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants