Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better document sage.el #1861

Closed
williamstein opened this issue Jan 20, 2008 · 13 comments
Closed

better document sage.el #1861

williamstein opened this issue Jan 20, 2008 · 13 comments

Comments

@williamstein
Copy link
Contributor

The page here http://www.sagemath.org/emacs has a file sage.el that is slightly modified from the ipython.el file. The documentation of this fact should be clearly stated in the file sage.el, along with some instructions about how to use it and the above URL.

Somebody could fix this and attach the fixed sage.el to this ticket.

Component: user interface

Author: Ivan Andrus

Reviewer: Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/1861

@williamstein williamstein added this to the sage-5.1 milestone Jan 20, 2008
@williamstein williamstein self-assigned this Jan 20, 2008
@williamstein
Copy link
Contributor Author

comment:1

By the way, this bug was reported by Dan Grayson.

@gvol
Copy link
Contributor

gvol commented May 25, 2012

comment:3

This has been superseded by the optional sage-mode spkg.

@gvol gvol removed this from the sage-5.1 milestone May 25, 2012
@kcrisman
Copy link
Member

comment:4

Plus, there isn't even an emacs page at sagemath.org any more. http://wiki.sagemath.org/sage-mode is the new place to go. It does have a lot better documentation.

To be pedantic, I would point out that the current (0.6) spkg doesn't actually say that this is inherited from ipython.el. It is sort of implied in sage-mode-0.6/old/README.txt; is that enough?

@gvol
Copy link
Contributor

gvol commented Jun 28, 2012

comment:5

Since we don't use the old directory anymore (I'm planning to remove it in the next release), and I'm pretty sure the new stuff isn't derived from ipython.el I think this should be closed as won't fix.

@kcrisman
Copy link
Member

comment:6

Okay, I'll say that's okay as long as (to honor this ticket) somewhere in the documentation, wiki, bitbucket, whatever, there is a place that says this was inspired by ipython.el originally. Sound good? I'll put that on #13176, which is for upgrading to 0.7.

@kcrisman
Copy link
Member

Reviewer: Ivan Andrus, Karl-Dieter Crisman

@gvol
Copy link
Contributor

gvol commented Jun 29, 2012

comment:7

I updated the wiki, and SPKG.txt.

@kcrisman
Copy link
Member

comment:8

Great, this is an immediate improvement on the wiki, and 0.8 has this as well. Putting back to a "normal" milestone since #13176 is slightly more complex.

@kcrisman
Copy link
Member

Author: Ivan Andrus

@kcrisman
Copy link
Member

Changed reviewer from Ivan Andrus, Karl-Dieter Crisman to Karl-Dieter Crisman

@kcrisman kcrisman added this to the sage-5.2 milestone Jun 29, 2012
@jdemeyer
Copy link
Contributor

comment:9

Replying to @kcrisman:

Great, this is an immediate improvement on the wiki, and 0.8 has this as well. Putting back to a "normal" milestone since #13176 is slightly more complex.

So, this has positive_review but no patch and not a duplicate? What is it then?

@kcrisman
Copy link
Member

comment:10

It's sort of like when someone opens a ticket to do something on Trac itself (create a new report, let's say). Here, updating the wiki and having upstream incorporate this last thing in all future versions was sufficient. After all, the original ticket was just to change a webpage - no patch was really required there.

If you'd really like, I can make a patch from the changeset and these others, attach them here, and we can wait until Ivan actually releases another one or something, but according to the original issue, the changes at the wiki are already more than sufficient. Basically, I figure that the person who actually makes things easier to figure out deserves at least some credit.

@jdemeyer
Copy link
Contributor

comment:11

Okay, that's clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants