Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module_list.py: remove foo_depends variables #18837

Closed
jdemeyer opened this issue Jul 1, 2015 · 6 comments
Closed

module_list.py: remove foo_depends variables #18837

jdemeyer opened this issue Jul 1, 2015 · 6 comments

Comments

@jdemeyer
Copy link
Contributor

jdemeyer commented Jul 1, 2015

These days, Cython knows that included files are a dependency. So in most cases, the

depends = [...]

lines in module_list.py are not needed.

This ticket removes flint_depends, singular_depends and givaro_depends with one exception: the dependency of sage.libs.linbox.linbox on Givaro is not automatically detected (I don't know whether it's a real dependency, but I'm keeping the explicit dependency to be safe).

To check that Cython really knows the dependencies, you can check the metadata on top of each generated .c/.cpp file. You will see that (with the one exception mentioned before), Cython knows the dependencies.

Note that in some cases, flint/flint.h was a dependency before but not after this ticket. In all those cases, other FLINT files like flint/ulong_extras.h are still a dependency, so this is not a problem.

CC: @jpflori

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 37a7a10

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/18837

@jdemeyer jdemeyer added this to the sage-6.8 milestone Jul 1, 2015
@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jul 1, 2015

Branch: u/jdemeyer/ticket/18837

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jul 1, 2015

Commit: 37a7a10

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jul 1, 2015

New commits:

37a7a10Remove foo_depends variables

@jpflori
Copy link
Contributor

jpflori commented Jul 2, 2015

Reviewer: Jean-Pierre Flori

@vbraun
Copy link
Member

vbraun commented Jul 2, 2015

Changed branch from u/jdemeyer/ticket/18837 to 37a7a10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants