Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove three class constructors from designs.<tab> #19096

Closed
nathanncohen mannequin opened this issue Aug 26, 2015 · 12 comments
Closed

Remove three class constructors from designs.<tab> #19096

nathanncohen mannequin opened this issue Aug 26, 2015 · 12 comments
Labels
c: combinatorial designs p: major / 3 t: bug
Milestone
sage-6.9

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Aug 26, 2015

As discussed on #18972, the following three entries should not be in designs.<tab>, which is for the moment meant to hold the constructors of our database of designs, i.e. OA, TD, t-designs, etc ...

designs.IncidenceStructure
designs.Hypergraph
designs.BlockDesign

While our policy may eventually change on this respect, this branch enforces what I believe is the current standard.

Nathann

Depends on #18972

CC: @dimpase

Component: combinatorial designs

Author: Nathann Cohen

Branch/Commit: d21a20d

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/19096
@nathanncohen nathanncohen mannequin added this to the sage-6.9 milestone Aug 26, 2015
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 26, 2015

Commit: 04200c4

@nathanncohen

This comment has been minimized.

Sign in to view
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 26, 2015

Last 10 new commits:

3350efcinplace has arrived here too
4e077dbmaking internet and gap_packages tests optional
0d20a94inplace has arrived here too
7d15addtrac #18972: Speedup is_twograph
7a690detrac #18972: speedup Graph.twograph
4e3a0eaMerge branch 'public/18972' of git://trac.sagemath.org/sage into HEAD
95fe0f2Merge remote-tracking branch 'trac/public/18972' into seidelsw
25eec1buniformity, but no regularity
a729b27the reviwer has cooked and has eaten my brain (removed stuff from designs.*)
04200c4trac #19096: Remove three class constructors from designs.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 26, 2015

Branch: public/19096

@nathanncohen nathanncohen mannequin added the s: needs review label Aug 26, 2015
@fchapoton
Copy link
Contributor

comment:2

2 failing doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 27, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

d21a20dtrac #19096: Broken doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 27, 2015

Changed commit from 04200c4 to d21a20d

@fchapoton
Copy link
Contributor

comment:5

ok, looks good to me.

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 31, 2015

comment:6

Thanks !

Nathann

@vbraun
Copy link
Member

vbraun commented Aug 31, 2015

comment:7

Reviewer name

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Sep 2, 2015

Changed branch from public/19096 to d21a20d

@vbraun vbraun closed this as completed in 1adb3aa Sep 2, 2015
@jdemeyer jdemeyer mentioned this issue May 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorial designs p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.9
Development

No branches or pull requests
2 participants
@vbraun @fchapoton