latex names

[sagetrac-fwclarke]

As pointed out in http://ask.sagemath.org/question/31223, there are various problems with defining latex_name for the generators of number fields. For example

sage: K.<a> = NumberField(x^3 - 5, latex_name='alpha')
sage: latex(a), K.latex_variable_name()
(alpha, 'alpha')
sage: y = polygen(K, 'y')
sage: L.<b> = K.extension(y^3 + a - 1, latex_name='beta')
sage: latex(b), L.latex_variable_name()
(b, 'beta')
sage: M.<c> = NumberField(y^3 + a - 1, latex_name='gamma')
sage: latex(c), M.latex_variable_name()
(c, 'c')

These, and some other, inconsistencies need ironing out.

Depends on #30372

CC: @tscrim @kliem

Component: number fields

Keywords: latex_name

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19657

[sagetrac-fwclarke]

Changed keywords from none to latex_name

[sagetrac-fwclarke]

Branch: u/fwclarke/latex_names

[sagetrac-git]

Commit: 65fb4a2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

65fb4a2

fix NumberFieldFactory

[sagetrac-fwclarke]

comment:4

First we ensure that NumberFieldFactory passes latex_name on in every case. Now

sage: K.<a> = NumberField(x^3 - 5)
sage: y = polygen(K, 'y')
sage: M.<c> = NumberField(y^3 + a - 1, latex_name='gamma')
sage: latex(c), M.latex_variable_name()
(c, 'gamma')

[sagetrac-git]

Changed commit from 65fb4a2 to 807b378

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

807b378

fix latex_name for variable fields and latex_variable_names

[sagetrac-fwclarke]

comment:6

Now require that the extension method passes on latex_name, that the NumberField_generic class defines the _latex_names attribute so that the latex_variable_names method works as it should, and similarly that the NumberField_relative class defines that attribute appropriately. This gives

sage: K.<a> = NumberField(x^3 - 6, latex_name='alpha')
sage: K.latex_variable_names()
['alpha']
sage: L.<b> = K.extension(x^2 - 5, latex_name='beta')
sage: L.latex_variable_names()
['beta', 'alpha']

[sagetrac-git]

Changed commit from 807b378 to 71bfd96

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

71bfd96

adjust _latex for elements of relative number fields

[sagetrac-git]

Changed commit from 71bfd96 to f0abaf3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f0abaf3

Treat latex_names in a similar manner to names

[sagetrac-git]

Changed commit from f0abaf3 to 794f6bb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

794f6bb

doctests

[sagetrac-fwclarke]

Author: Francis Clarke

[rwst]

Work Issues: merge conflict

[mkoeppe]

comment:12

See also #30372 - Replace NumberField_generic.__latex_variable_name by ._latex_names

[mkoeppe]

Changed work issues from merge conflict to merge with #30372

[mkoeppe]

Dependencies: #30372

[mkoeppe]

comment:14

I have taken some of the commits here and merged/reworked them in #30360, where I did similar work.
This ticket can be closed.

[tscrim]

Changed work issues from merge with #30372 to none

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

Changed author from Francis Clarke to none

[slel]

Changed commit from 794f6bb to none

[slel]

Changed branch from u/fwclarke/latex_names to none