Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctest fix for tan(complex).imag() wrong #19791

Closed
rwst opened this issue Dec 28, 2015 · 11 comments
Closed

doctest fix for tan(complex).imag() wrong #19791

rwst opened this issue Dec 28, 2015 · 11 comments
Labels
c: symbolics p: major / 3 t: bug
Milestone
sage-7.0

Comments

@rwst
Copy link
Contributor

rwst commented Dec 28, 2015 

sage: tan(2+I).n()
-0.243458201185725 + 1.16673625724092*I
sage: tan(2+I).imag().n()
0.0605381745356926
sage: tan(2+I).imag()
tanh(1)/(tan(2)^2*tan(1)^2 + 1)

There is a form that works at
http://dlmf.nist.gov/4.21.E39

See pynac/pynac#114

Since this is fixed in Sage now, this ticket should provide doctests.

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 7a617e3

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/19791
@rwst rwst added this to the sage-7.0 milestone Dec 28, 2015
@rwst
Copy link
Contributor Author

rwst commented Dec 28, 2015

Changed upstream from Reported upstream. Developers acknowledge bug. to Fixed upstream, in a later stable release.

@rwst
Copy link
Contributor Author

rwst commented Dec 28, 2015

comment:1

That bug is in GiNaC too. Fix is in pynac git master, so will be in pynac-0.5.4.

@slel
Copy link
Member

slel commented Jan 13, 2016

comment:2

Fixed by update to Pynac 0.6.0 at #19819?

@rwst

This comment has been minimized.

Sign in to view
@rwst
Copy link
Contributor Author

rwst commented Jan 18, 2016

Branch: u/rws/tan_complex__imag___wrong

@rwst
Copy link
Contributor Author

rwst commented Jan 18, 2016

Author: Ralf Stephan

@rwst
Copy link
Contributor Author

rwst commented Jan 18, 2016

Changed upstream from Fixed upstream, in a later stable release. to none

@rwst
Copy link
Contributor Author

rwst commented Jan 18, 2016

New commits:

7a617e319791: doctest fix for tan.imag

@rwst
Copy link
Contributor Author

rwst commented Jan 18, 2016

Commit: 7a617e3

@rwst rwst changed the title tan(complex).imag() wrong doctest fix for tan(complex).imag() wrong Jan 18, 2016
@jdemeyer
Copy link
Contributor

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Jan 20, 2016

Changed branch from u/rws/tan_complex__imag___wrong to 7a617e3

@vbraun vbraun closed this as completed in 8ba9f5b Jan 20, 2016
This was referenced Jan 7, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: major / 3 t: bug
Projects
None yet
Milestone
sage-7.0
Development

No branches or pull requests
4 participants
@vbraun @rwst @slel @jdemeyer