Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new structure for extended codes #20124

Closed
sagetrac-dlucas mannequin opened this issue Feb 26, 2016 · 24 comments
Closed

A new structure for extended codes #20124

sagetrac-dlucas mannequin opened this issue Feb 26, 2016 · 24 comments

Comments

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Feb 26, 2016

This ticket proposes a new implementation for extended codes.

It contains:

  • a new code class, ExtendedCode

  • a dedicated encoder to compute the generator matrix of an Extended Code.

  • a dedicated decoder which uses the original code to correct errors

Depends on #19653

Component: coding theory

Author: David Lucas

Branch/Commit: e54ef7f

Reviewer: Julien Lavauzelle

Issue created by migration from https://trac.sagemath.org/ticket/20124

@sagetrac-dlucas sagetrac-dlucas mannequin added this to the sage-7.1 milestone Feb 26, 2016
@sagetrac-dlucas

This comment has been minimized.

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 26, 2016

Branch: u/dlucas/extended_codes

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 26, 2016

Dependencies: #19653

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 26, 2016

comment:3

I pushed the branch, this is now open for review.


Last 10 new commits:

c4ca177Better doctests for Error-Erasure decoder, added sanity check on decode_to_messaage's input
a074cb8Changed my helper methods into private methods
6ad583fFixed bug in KeyEquation decoder's decode_to_code, added sanity checks, enhanced doctests
fca099eAdded new sanity check on the output of BW and Gao decoder
57dbfbfRewrote random_element method
7953d60Proper sanity checks for output of decode_to_* methods
8673ac5Optimized a bit polynomial division in Gao and BW
e1b6b09Merged now postive reviewed #19666 and fixed conflicts
f66aa6cMerged branch related to GRS decoders
561ccd4Added random_element method, fixed decoder so it handles properly list-decoders

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 26, 2016

Author: David Lucas

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Feb 26, 2016

Commit: 561ccd4

@johanrosenkilde
Copy link
Contributor

comment:4

Shouldn't LinearCode.extended_code use this?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2016

Changed commit from 561ccd4 to 8b81ae3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

e0f6692Merge branch 'develop' into extended_codes
8b81ae3extended_code() method over linear codes now returns an ExtendedCode object. Fixed related doctests.

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented Apr 1, 2016

comment:6

Definitely. And it does now!

David

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2016

Changed commit from 8b81ae3 to 57ebe0c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

57ebe0cUpdated to 7.3b1 and fixed conflicts

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented May 25, 2016

comment:8

Hello,

I fixed conflicts that arose after the update to Sage 7.3beta1.
This is still open for review.

David

@sagetrac-dlucas sagetrac-dlucas mannequin modified the milestones: sage-7.1, sage-7.3 May 25, 2016
@jlavauzelle
Copy link
Contributor

Changed branch from u/dlucas/extended_codes to u/jlavauzelle/extended_codes

@jlavauzelle
Copy link
Contributor

Changed commit from 57ebe0c to 784975a

@jlavauzelle
Copy link
Contributor

comment:10

Hi David,

I fixed some stuff in the doc, add sanity check and modified the decoding_radius method. Green light for the rest of the code.

Best,

Julien


New commits:

594e46cMerge branch 'u/dlucas/extended_codes' of git://trac.sagemath.org/sage into u/jlavauzelle/extended_codes
0289f90Merge branch 'u/dlucas/extended_codes' of git://trac.sagemath.org/sage into u/jlavauzelle/extended_codes
d05bfc4Fix the documentation.
784975aAdded sanity checks. Fixed decoding_radius method arguments.

@jlavauzelle
Copy link
Contributor

Reviewer: Julien Lavauzelle

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented May 30, 2016

Changed branch from u/jlavauzelle/extended_codes to u/dlucas/extended_codes

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented May 30, 2016

Changed commit from 784975a to 04e48ae

@sagetrac-dlucas
Copy link
Mannequin Author

sagetrac-dlucas mannequin commented May 30, 2016

comment:12

Hello,

There was a few broken doctests, which I fixed.
I agree with the changes you made on the ticket, and if you're ok with my fix, you can set this to positive_review.

Best,

David


New commits:

04e48aeFixed broken doctests

@jlavauzelle
Copy link
Contributor

Changed branch from u/dlucas/extended_codes to u/jlavauzelle/extended_codes

@jlavauzelle
Copy link
Contributor

Changed commit from 04e48ae to e54ef7f

@jlavauzelle
Copy link
Contributor

comment:14

Hi David,

I agree with your fixes. Tests passed, doc is okay. I give the positive review.

Best,

Julien


New commits:

e54ef7fMerge branch 'develop' into t/20124/extended_codes

@vbraun
Copy link
Member

vbraun commented Jun 18, 2016

Changed branch from u/jlavauzelle/extended_codes to e54ef7f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants