Fix Relative Field Extensions

[jlavauzelle]

This tickets aims at fixing some minors bugs in the experimental class RelativeFiniteFieldExtension.

CC: @sagetrac-dlucas

Component: coding theory

Author: Julien Lavauzelle

Branch/Commit: 2510d2b

Reviewer: David Lucas

Issue created by migration from https://trac.sagemath.org/ticket/20951

[jlavauzelle]

Branch: u/jlavauzelle/fix_relative_field_extensions

[jlavauzelle]

Author: Julien Lavauzelle

[jlavauzelle]

Changed branch from u/jlavauzelle/fix_relative_field_extensions to none

[jlavauzelle]

comment:2

Hi,

I fixed ambiguity in the documentation of some functions. I also fixed a minor bug in the method relative_field_representation.

I added a function which basically invert the relative field embedding (I mean, given an absolute field element x which actually lies in the relative field, the function cast x into the relative field).

Didn't check the other methods.

Open for review.

Julien

[jlavauzelle]

Branch: u/jlavauzelle/fix_relative_field_extensions

[jlavauzelle]

New commits:

f77da55	Fixed the doc. Fixed the case s==1 in relative_field_representation().
819cbb9	Add the inverse function of the relative field embedding.

[jlavauzelle]

Commit: 819cbb9

[sagetrac-git]

Changed commit from 819cbb9 to 17bf28d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

17bf28d

Replaced "power" by "degree" when dealing with the extension degree of a field. Added an enxtension_degree() method.

[jlavauzelle]

comment:6

Hi,

I reviewed the rest of the class and modified some names (basically 'degree' instead of 'power'). I also added a function to give the extension degree between the medium and the big field, as we often need it.

Open for review.

Julien

[sagetrac-dlucas]

Changed branch from u/jlavauzelle/fix_relative_field_extensions to u/dlucas/fix_relative_field_extensions

[sagetrac-dlucas]

Changed commit from 17bf28d to 2510d2b

[sagetrac-dlucas]

Reviewer: David Lucas

[sagetrac-dlucas]

comment:8

Hello,

I made two small changes:

• There was an indentation error in the docstring of cast_into_relative_field, which I fixed.
• In Python, it's not necessary to write if (check):, if check: is enough :). Thus I removed the unnecessary parenthesis.

Otherwise, it's good to go! If you agree with my tiny changes, you can set it to positive_review.
Thanks for your fixes.

BTW, the patchbot doctests error due to guava.py have been fixed in #20952.

Best,

David

---

New commits:

6ace61b	Fixed small bug in documentation
2510d2b	Removed unnecessary parenthesis

[jlavauzelle]

comment:9

Hi David,

That's ok for me. I put it in positive review.

Thanks,

Julien

[vbraun]

Changed branch from u/dlucas/fix_relative_field_extensions to 2510d2b