AbstractLinearCode.dimension() is wrong if _dimension is not set

[johanrosenkilde]

The current implementation of AbstractLinearCode.dimension() simply accesses self._dimension. But there is no (longer a) requirement that this be set at construction time. The method should instead check if the special variable is set, and if it is not, compute the dimension as the number of rows in a generator matrix.

CC: @sagetrac-dlucas

Component: coding theory

Keywords: linear code, rd3

Author: Bruno Grenet

Branch/Commit: b72b705

Reviewer: Johan Rosenkilde

Issue created by migration from https://trac.sagemath.org/ticket/21156

[bgrenet]

comment:1

I implemented a fix.

[bgrenet]

New commits:

4a8613e	21156: Compute dimension if not already known
8c994a6	21156: Add tests (+ minor typo)

[bgrenet]

Branch: u/bruno/abstractlinearcode_dimension___is_wrong_if___dimension__is_not_set

[bgrenet]

Commit: 8c994a6

[sagetrac-git]

Changed commit from 8c994a6 to fb83a25

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fb83a25

21156: Better doctest

[johanrosenkilde]

Changed branch from u/bruno/abstractlinearcode_dimension___is_wrong_if___dimension__is_not_set to u/jsrn/abstractlinearcode_dimension___is_wrong_if___dimension__is_not_set

[johanrosenkilde]

Changed commit from fb83a25 to b72b705

[johanrosenkilde]

comment:5

Added a note about the _registered_encoder that bruno ran into when writing the doc test.

Otherwise good, setting positive review.

---

New commits:

b72b705

Added note on class-level registration dictionaries to the doc.

[johanrosenkilde]

Reviewer: Johan Rosenkilde

[johanrosenkilde]

Author: Bruno Grenet

[johanrosenkilde]

Changed keywords from linear code to linear code, rd3

[vbraun]

Changed branch from u/jsrn/abstractlinearcode_dimension___is_wrong_if___dimension__is_not_set to b72b705