Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to systematic encoder for linear codes #21157

Closed
johanrosenkilde opened this issue Aug 3, 2016 · 10 comments
Closed

Improvements to systematic encoder for linear codes #21157

johanrosenkilde opened this issue Aug 3, 2016 · 10 comments

Comments

@johanrosenkilde
Copy link
Contributor

#20835 introduced a systematic encoder for linear codes which always obtains as the systematic positions the lexicographically minimal possibility. It would be nice if the user could specify the systematic positions.

At the same time, one could improve some methods of AbstractLinearCode to take advantage of the new improved systematic capabilities.

Depends on #20835

CC: @sagetrac-dlucas

Component: coding theory

Keywords: linear code

Author: Johan Rosenkilde

Branch/Commit: e46b9ff

Reviewer: David Lucas

Issue created by migration from https://trac.sagemath.org/ticket/21157

@johanrosenkilde
Copy link
Contributor Author

Branch: u/jsrn/21157_improved_systematic

@johanrosenkilde
Copy link
Contributor Author

comment:2

I've implemented the systematic encoder improvements as well as employed the new capabilities to simplify a few methods in AbstractLinearCode.


Last 10 new commits:

3a2f5acFixes to LinearCodeSystematicEncoder doc
a8a37bdImplement optional systematic positions + examples
084fcc4Fixed bug. Added example/test for non-information set systematic_positions
11a0e31Shortcut with AbstractLinearCode.systematic_generator_matrix
e26a379information_set can use systematic encoder
9e80364Added is_information_set
4d56371Simplified permuted_code (noticed in passing, nothing to do with systematic)
bc6b129Simplified redundancy_matrix and improved its documentation
6882f91Massively simplified AbstractLinearCode.standard_form and improved its doc
e46b9ffSmall doc improvements

@johanrosenkilde
Copy link
Contributor Author

Changed keywords from linear cod to linear code

@johanrosenkilde
Copy link
Contributor Author

Commit: e46b9ff

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Aug 4, 2016

comment:3

Hello,

Tests pass and documentation builds, and you made nice improvements (included a few I was about to open a ticket for, like the improvement to redundancy_matrix's doc :)).

I give this ticket a positive review.

David

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Aug 4, 2016

Dependencies: #20835

@vbraun
Copy link
Member

vbraun commented Aug 5, 2016

comment:4

Reviewer name is missing

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Aug 6, 2016

Reviewer: David Lucas

@sagetrac-dlucas
Copy link
Mannequin

sagetrac-dlucas mannequin commented Aug 6, 2016

comment:5

Sorry...

Done now.

David

@vbraun
Copy link
Member

vbraun commented Aug 7, 2016

Changed branch from u/jsrn/21157_improved_systematic to e46b9ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants