- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorter printing of core linear code objects #21691
Comments
Commit: |
Changed branch from u/jsrn/improve_linear_code_messages to u/jlavauzelle/improve_linear_code_messages |
comment:4
Hi Johan, Nice changes, it makes it really more readable. I only have one suggestion for punctured codes. You wrote for instance: I also made 3 optional doctests pass in guava.py and merge with the latest beta (7.5.beta1). Julien New commits:
|
Reviewer: Julien Lavauzelle |
comment:5
Hi Julien, I would make the change, but I'm running some heavy computations and I'm worried that I'll break something by recompiling and experimenting. Could you do it? Best, |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Hi Johan, I did that change. Patchbot also found doctest failures in some crazy tutorials (one about linear codes and ciphers, the other about graphs...). I fixed them. I'll wait your green light on my changes to give the positive review. Best, Julien |
comment:8
It looks great, thanks a lot! |
Changed branch from u/jlavauzelle/improve_linear_code_messages to |
The central objects for linear codes in Sage prints unnecessarily long, even though there are established conventions for shorter description. This ticket proposes a change to that:
Printing
GF(8)
is the only controversial thing here, from a Sage POV. Theargument is that linear codes are always over finite fields, so it is
unnecessarily verbose to insist on the long printing. (formally, using
LinearCode
over a ring has not been deprecated yet, see #20387, but a code over a ring is not a "linear code" in the classical sense)Other proposed changes are:
Generalized Reed-Solomon Code
->Reed-Solomon Code
(whenever the column multipliers are all-1)Extended code coming from <bla>
->Extension of <bla>
Punctured code coming from <bla>
->Puncturing of <bla>
Subfield subcode over <subfield> coming from <code>
->Subfield subcode of <bla> down to <subfield>
Related objects (e.g. encoders and decoders) have been shortened similarly
(though much more could be done here).
An unrelated change which I put here anyway is a polishing of
AbstractLinearCode
's class doc, and improved error messages for itsencoder()
anddecoder()
methods.CC: @sagetrac-dlucas @jlavauzelle
Component: coding theory
Keywords: linear_code
Author: Johan Rosenkilde
Branch/Commit:
2316e35
Reviewer: Julien Lavauzelle
Issue created by migration from https://trac.sagemath.org/ticket/21691
The text was updated successfully, but these errors were encountered: