Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow algorithm='sympy' in symbolic_sum function #22004

Closed
seblabbe opened this issue Dec 1, 2016 · 15 comments
Closed

Allow algorithm='sympy' in symbolic_sum function #22004

seblabbe opened this issue Dec 1, 2016 · 15 comments

Comments

@seblabbe
Copy link
Contributor

seblabbe commented Dec 1, 2016

I want this to work:

sage: n = var('n')
sage: sum(1/((2*n+1)^2-4)^2, n, 0, Infinity, algorithm='sympy')

See this question on ask.sagemath.org

CC: @kcrisman

Component: symbolics

Author: Sébastien Labbé

Branch/Commit: 16acdcf

Reviewer: Ralf Stephan

Issue created by migration from https://trac.sagemath.org/ticket/22004

@seblabbe seblabbe added this to the sage-7.5 milestone Dec 1, 2016
@seblabbe
Copy link
Contributor Author

seblabbe commented Dec 1, 2016

Branch: u/slabbe/22004

@seblabbe
Copy link
Contributor Author

seblabbe commented Dec 1, 2016

Commit: aa2bcc1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 1, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

a0f8d1722004: Allow algorithm='sympy' in symbolic_sum function

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 1, 2016

Changed commit from aa2bcc1 to a0f8d17

@kcrisman
Copy link
Member

kcrisman commented Dec 1, 2016

comment:4

(Incidentally, the example here, which doesn't work right with Maxima, may be related to https://sourceforge.net/p/maxima/bugs/3236/.)

@kcrisman
Copy link
Member

kcrisman commented Dec 1, 2016

comment:5

Also,

         sage: symbolic_sum(1/(1+k^2), k, -oo, oo, algorithm = 'giac')           # optional - giac
         (pi*e^(2*pi) - pi*e^(-2*pi))/(e^(2*pi) + e^(-2*pi) - 2)
+    SymPy can't solve that summation::
+

You will need an extra blank line for formatting. I'd also say that Maxima can't do the sum in this ticket, not that Sage per se can't - indeed, Sage can after this patch!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 1, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

16acdcf22004: fixing doc comment

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 1, 2016

Changed commit from a0f8d17 to 16acdcf

@seblabbe
Copy link
Contributor Author

seblabbe commented Dec 1, 2016

comment:7

On my screen, the extra blank line is already there. Can you confirm this problem?

I wrote Maxima instead of Sage. Needs review!

@kcrisman
Copy link
Member

kcrisman commented Dec 1, 2016

comment:8

Huh, now it appears fine. Go figure.

Wish I had time to do proper review :( don't even have up-to-date Sage (compiling). These comments are what I could do for now, and as long as someone checks it works right and "corner cases" don't yield errors you haven't caught, I definitely say positive review!

@rwst
Copy link
Contributor

rwst commented Dec 2, 2016

comment:9

I really see no problem with this addition. Now that there is a symbolic sum in Sage the conversion of unsolved sums from SymPy will only need a small SymPy patch (in the SymPy repo or in build/pkgs/sympy) to work.

@rwst
Copy link
Contributor

rwst commented Dec 2, 2016

Reviewer: Ralf Stephan

@vbraun
Copy link
Member

vbraun commented Dec 2, 2016

comment:10

Author name is missing...

@tscrim
Copy link
Collaborator

tscrim commented Dec 3, 2016

Author: Sébastien Labbé

@vbraun
Copy link
Member

vbraun commented Dec 5, 2016

Changed branch from u/slabbe/22004 to 16acdcf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants