Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve method PowerSeries._pari_() #22212

Closed
pjbruin opened this issue Jan 19, 2017 · 9 comments
Closed

Improve method PowerSeries._pari_() #22212

pjbruin opened this issue Jan 19, 2017 · 9 comments

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Jan 19, 2017

A minor improvement split off from #15601. This makes the method PowerSeries._pari_() slightly more efficient, and also makes it accept power series with infinite precision (by converting them to PARI t_POL instead of t_SER).

Depends on #22216

Component: interfaces

Author: Peter Bruin

Branch/Commit: 4ed448f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22212

@pjbruin pjbruin added this to the sage-7.6 milestone Jan 19, 2017
@pjbruin
Copy link
Contributor Author

pjbruin commented Jan 20, 2017

Commit: 4ed448f

@pjbruin
Copy link
Contributor Author

pjbruin commented Jan 20, 2017

Branch: u/pbruin/22212-PowerSeries_to_pari

@pjbruin
Copy link
Contributor Author

pjbruin commented Jan 20, 2017

Dependencies: #22216

@pjbruin

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Jan 25, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 25, 2017

comment:4

If PARI doesn't care so much about the difference between a polynomial and a series (I don't really know how PARI deals with these things), then LGTM and you can set a positive review.

@pjbruin
Copy link
Contributor Author

pjbruin commented Jan 25, 2017

comment:5

Replying to @tscrim:

If PARI doesn't care so much about the difference between a polynomial and a series (I don't really know how PARI deals with these things), then LGTM and you can set a positive review.

Thanks. In PARI, polynomials and power series can be mixed easily, just like in Sage polynomial rings coerce into power series rings. In fact, power series with infinite precision are implemented in #15601 using PARI polynomials.

@tscrim
Copy link
Collaborator

tscrim commented Jan 25, 2017

comment:6

Replying to @pjbruin:

Replying to @tscrim:

If PARI doesn't care so much about the difference between a polynomial and a series (I don't really know how PARI deals with these things), then LGTM and you can set a positive review.

Thanks. In PARI, polynomials and power series can be mixed easily, just like in Sage polynomial rings coerce into power series rings. In fact, power series with infinite precision are implemented in #15601 using PARI polynomials.

Thank you for the explanation. That is what I was thinking, but it is good to have confirmation.

@vbraun
Copy link
Member

vbraun commented Jan 29, 2017

Changed branch from u/pbruin/22212-PowerSeries_to_pari to 4ed448f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants