Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "yield" in CGraphBackend.iterator_verts #22383

Closed
jdemeyer opened this issue Feb 15, 2017 · 6 comments
Closed

Use "yield" in CGraphBackend.iterator_verts #22383

jdemeyer opened this issue Feb 15, 2017 · 6 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@jdemeyer
Copy link
Contributor

Instead of constructing some container and then returning an iterator over that container, use yield directly.

CC: @mezzarobba

Component: graph theory

Author: Jeroen Demeyer

Branch/Commit: 507428d

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/22383
@jdemeyer jdemeyer added this to the sage-7.6 milestone Feb 15, 2017
@jdemeyer jdemeyer changed the title Use "yield" in c_graph.iterator_verts Use "yield" in CGraphBackend.iterator_verts Feb 15, 2017
@jdemeyer
Copy link
Contributor Author

Branch: u/jdemeyer/use__yield__in_c_graph_iterator_verts

@jdemeyer
Copy link
Contributor Author

Commit: 507428d

@jdemeyer
Copy link
Contributor Author

New commits:

507428dUse "yield" in CGraphBackend.iterator_verts

@dcoudert
Copy link
Contributor

comment:4

Passes all tests on src/sage/graphs/, and the changes in the doctests are correct (I checked). So good to go.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@vbraun
Copy link
Member

vbraun commented Feb 21, 2017

Changed branch from u/jdemeyer/use__yield__in_c_graph_iterator_verts to 507428d

@vbraun vbraun closed this as completed in f5e3391 Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @dcoudert