-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support interface coercion polymake(X) for Polyhedron #22658
Comments
comment:1
I immediately ran into a problem:
When I enter the same a second time, I get this interesting "recompilation failure"...
|
comment:3
The problem arises when converting the list of lists of integers:
|
comment:4
The interesting thing is that in the file there is no reference to a variable. Instead, a variable (with a different name) is defined in the file. |
comment:5
Is that a bug in polymake, perhaps? The content of the file is
When I feed this directly into polymake, all is fine. But when I read it as a script, I get
Question to polymake experts: Is polymake interpreting a script differently from a user interaction? |
comment:6
I posted the question in the polymake forum |
comment:7
Apparently it is safer to use That said, after changing the
Also, the following is not what I was hoping for:
|
comment:8
Probably the reason for the new error is that on the command line, a variable can be declared only once. But certainly Perl/polymake allows to explicitly un-declare a variable. So, as soon I have found out how to un-declare, I can fix that. |
comment:9
It REALLY SUCKS that trac keeps logging me out automatically after short time! What I wanted to say: At polymake forum I was told that scripts somehow are cached - which basically means that the use of scripts in order to send commands to polymake is leaking memory. So, perhaps better disallow using files. When I do it, the definition of the polytope initially seems to work:
but alas, something goes foobar:
whereas in a polymake session I get
|
comment:10
The interface seems to be out of sync in the example above:
Or perhaps there is a different reason:
So, sometimes the attribute error is stable, sometimes it vanishes. |
comment:11
Replying to @simon-king-jena:
Maybe because your IP address changes automatically? |
comment:12
Replying to @jplab:
You mean my IP address could change while being connected to eduroam, or also while being connected to ethernet? |
comment:14
By the way, would it make it easier for you to stay synced if there was no terminal echo? Last 10 new commits:
|
Commit: |
Changed branch from u/SimonKing/polyhedron_methods_using_the_polymake_pexpect_interface to none |
Changed commit from |
comment:15
Replying to @simon-king-jena:
But it does work if I simply disallow the use of files and do not change the declaration of variables. So, I provided a quick fix plus doctest. |
Author: Simon King |
Dependencies: #22452 |
comment:17
Yes, actually, the same just happened to me now to come and write this comment and I'm using eduroam (without a lan connection at the same time) ...and this never happened to me in Olot for example. It is explains anything at all... |
Changed author from Simon King to none |
Changed dependencies from #22452 to none |
Commit: |
Author: Simon King |
Dependencies: #22452 |
comment:69
Also, in the interfaces, there are other similar large values, e.g.:
|
comment:70
Yes, no point worrying about these numbers. I guess some are based on historical testing, others based on cut and paste. In any case, the current value in the polymake interface works both on Mac OS X and Linux; and there are tests for it. |
comment:71
So what else needs to be done for reviewing this ticket? Is anyone currently actively finishing the review for this ticket? |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:73
Travis, I'm not aware of anyone else reviewing this ticket. |
comment:74
LGTM as far as I can tell. However, there are 2 minor issues from the patchbot:
|
This comment has been minimized.
This comment has been minimized.
Reviewer: Jean-Philippe Labbé, Travis Scrimshaw |
comment:77
I think this one is unnecessary:
Once that is reverted, then you can set a positive review on my behalf. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:79
Thank you! |
comment:80
|
comment:81
Looks like they just need |
Changed branch from u/mkoeppe/polyhedron_methods_using_the_polymake_pexpect_interface to |
Following up on the Polymake pexpect interface (#22452), we make it easy to make a polymake object corresponding to a given
Polyhedron
.We use the standard interface coercion protocol by defining
SageObject._polymake_
and a default methodSageObject._polymake_init_
, which is overridden forPolyhedron_base
and for several rings.Basic example (see
Polyhedron_base._polymake_init_
for more):Example of an algebraic polyhedron:
The branch is on top of #22452; and it also contains a quick fix for the polymake interface regarding the way that files are used to send long commands.
Depends on #22452
CC: @simon-king-jena @jplab @videlec @tscrim @yuan-zhou @dimpase
Component: geometry
Keywords: days84
Author: Matthias Koeppe, Simon King
Branch/Commit:
d7d4234
Reviewer: Jean-Philippe Labbé, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/22658
The text was updated successfully, but these errors were encountered: