Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polymake: Resolve clashes between global polymake user functions, polymake methods, Sage methods #22705

Open
mkoeppe opened this issue Mar 29, 2017 · 10 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 29, 2017

Examples for current failures:

    sage: polymake.application("tropical")
    sage: p = polymake.cartesian_product(polymake("uniform_linear_space<Max>(3,2)"),
    ....:                                polymake("uniform_linear_space<Max>(3,1)"))

Fails because cartesian_product is a Sage method already.

    sage: polymake.application("polytope")
    sage: c = polymake.cube(3)
    sage: c.save("cube3.poly")

Fails because save is a Sage method already.

    sage: polymake.application("tropical")
    sage: l = polymake("uniform_linear_space<Min>(3,2)")
    sage: l.bounding_box(1)                    

Clashes with the polymake global function of the same name.

Depends on #24905

CC: @simon-king-jena @jplab @dimpase

Component: interfaces

Keywords: days84

Issue created by migration from https://trac.sagemath.org/ticket/22705

@mkoeppe mkoeppe added this to the sage-8.0 milestone Mar 29, 2017
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 27, 2019

Dependencies: #24905

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 27, 2019

comment:2

These functions are made available in #24905 .... but save is still not accessible - that's shadowed by the Sage method of the same name.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title polymake: Make global polymake user functions such as 'save' available as methods polymake: Resolve clashes between global polymake user functions, polymake methods, Sage methods May 23, 2019
@mkoeppe mkoeppe modified the milestones: sage-8.0, sage-8.8 May 23, 2019
@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:4

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@embray embray removed this from the sage-8.8 milestone Jun 14, 2019
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 30, 2019

comment:5

Docstring of PolymakeFunctionElement::__call__:

        We consider both member functions of an element and global functions
        bound to an element::

            sage: p = polymake.rand_sphere(3, 13, seed=12)      # optional - polymake
            sage: p.get_schedule('"VERTICES"')                    # optional - polymake  # random
            sensitivity check for VertexPerm
            cdd.convex_hull.canon: POINTED, RAYS, LINEALITY_SPACE : INPUT_RAYS
            sage: p.minkowski_sum_fukuda(p).F_VECTOR            # optional - polymake
            13 33 22

Is this useful at all? This seems to cause the bounding_box clash.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 30, 2019

comment:6

A workaround is to use

l.get_member_function("bounding_box")(1) 

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 30, 2019

comment:7

Replying to @mkoeppe:

        We consider both member functions of an element and global functions
        bound to an element::

Is this useful at all? This seems to cause the bounding_box clash.

Ticket to remove this: #28281

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 1, 2020

comment:8

Moving some tickets to 9.2. This is not a promise that I will be working on them.

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 1, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:10

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe removed this from the sage-9.7 milestone Aug 31, 2022
@mkoeppe mkoeppe added this to the sage-9.8 milestone Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants