Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Pynac-0.7.6 #22838

Closed
rwst opened this issue Apr 20, 2017 · 31 comments
Closed

Upgrade to Pynac-0.7.6 #22838

rwst opened this issue Apr 20, 2017 · 31 comments

Comments

@rwst
Copy link
Contributor

rwst commented Apr 20, 2017

The Changelog:

https://github.com/pynac/pynac/releases/download/pynac-0.7.6/pynac-0.7.6.tar.bz2

Component: packages: standard

Author: Ralf Stephan

Branch/Commit: 6f8952a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22838

@rwst rwst added this to the sage-8.0 milestone Apr 20, 2017
@rwst

This comment has been minimized.

@rwst
Copy link
Contributor Author

rwst commented Apr 20, 2017

Branch: u/rws/upgrade_to_pynac_0_7_6

@rwst
Copy link
Contributor Author

rwst commented Apr 20, 2017

Author: Ralf Stephan

@rwst
Copy link
Contributor Author

rwst commented Apr 20, 2017

Commit: 7d3fd60

@rwst
Copy link
Contributor Author

rwst commented Apr 20, 2017

New commits:

3c848da22838: pkg version/checksum
d89e6d022838: remove unnecessary patch
4a3011922838: interface change
7d3fd6022838: doctest adaptation to ticket 10070

@mforets
Copy link
Mannequin

mforets mannequin commented Apr 20, 2017

comment:4

i'm getting that it cannot find pynac-0.7.6.tar.bz2 from mirrors.

maybe just delay in servers?

i did $ git trac checkout 22838 && make="MAKE -j4" make.

sage-logger -p 'sage-spkg pynac-0.7.6' '/Users/forets/sage-src/sage/logs/pkgs/pynac-0.7.6.log'
[pynac-0.7.6] Found local metadata for pynac-0.7.6
[pynac-0.7.6] Attempting to download package pynac-0.7.6.tar.bz2 from mirrors
[pynac-0.7.6] http://www.mirrorservice.org/sites/www.sagemath.org/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//www.mirrorservice.org/sites/www.sagemath.org/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirrors.fe.up.pt/pub/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirrors.fe.up.pt/pub/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirrors.mit.edu/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirrors.mit.edu/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirror.yandex.ru/mirrors/sage.math.washington.edu/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirror.yandex.ru/mirrors/sage.math.washington.edu/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://sage.mirror.garr.it/mirrors/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//sage.mirror.garr.it/mirrors/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://files.sagemath.org/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//files.sagemath.org/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirrors-usa.go-parts.com/sage/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirrors-usa.go-parts.com/sage/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirrors.xmission.com/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirrors.xmission.com/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://sagemath.mirror.ac.za/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//sagemath.mirror.ac.za/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirror.ufs.ac.za/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirror.ufs.ac.za/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://www-ftp.lip6.fr/pub/math/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//www-ftp.lip6.fr/pub/math/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://ftp.yz.yamagata-u.ac.jp/pub/math/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//ftp.yz.yamagata-u.ac.jp/pub/math/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirror.switch.ch/mirror/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirror.switch.ch/mirror/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://sunsite.rediris.es/mirror/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//sunsite.rediris.es/mirror/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://ftp.kaist.ac.kr/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//ftp.kaist.ac.kr/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://linorg.usp.br/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//linorg.usp.br/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://ftp.riken.jp/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//ftp.riken.jp/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://ftp.ntua.gr/pub/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//ftp.ntua.gr/pub/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://ftp.tsukuba.wide.ad.jp/software/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//ftp.tsukuba.wide.ad.jp/software/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirror.aarnet.edu.au/pub/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirror.aarnet.edu.au/pub/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://www.cecm.sfu.ca/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//www.cecm.sfu.ca/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://sagemath.polytechnic.edu.na/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//sagemath.polytechnic.edu.na/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://ftp.leg.uct.ac.za/pub/packages/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//ftp.leg.uct.ac.za/pub/packages/sage/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://sagemath.c3sl.ufpr.br/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//sagemath.c3sl.ufpr.br/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirrors.ustc.edu.cn/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirrors.ustc.edu.cn/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirrors.tuna.tsinghua.edu.cn/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirrors.tuna.tsinghua.edu.cn/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://mirror.hust.edu.cn/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//mirror.hust.edu.cn/sagemath/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] http://sagepad.org/spkg/upstream/pynac/pynac-0.7.6.tar.bz2
[pynac-0.7.6] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[pynac-0.7.6] ERROR [transfer|run:135]: [Errno 404] Not Found: '//sagepad.org/spkg/upstream/pynac/pynac-0.7.6.tar.bz2'
[pynac-0.7.6] Traceback (most recent call last):
[pynac-0.7.6]   File "/Users/forets/sage-src/sage/build/bin/sage-download-file", line 28, in <module>
[pynac-0.7.6]     run_safe()
[pynac-0.7.6]   File "/Users/forets/sage-src/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 118, in run_safe
[pynac-0.7.6]     run()
[pynac-0.7.6]   File "/Users/forets/sage-src/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 100, in run
[pynac-0.7.6]     app.download_tarball(args.url_or_tarball, args.destination)
[pynac-0.7.6]   File "/Users/forets/sage-src/sage/build/bin/../sage_bootstrap/download/app.py", line 43, in download_tarball
[pynac-0.7.6]     tarball.download()
[pynac-0.7.6]   File "/Users/forets/sage-src/sage/build/bin/../sage_bootstrap/tarball.py", line 161, in download
[pynac-0.7.6]     raise FileNotMirroredError('tarball does not exist on mirror network')
[pynac-0.7.6] sage_bootstrap.tarball.FileNotMirroredError: tarball does not exist on mirror network
[pynac-0.7.6] ************************************************************************
[pynac-0.7.6] Error downloading pynac-0.7.6.tar.bz2
[pynac-0.7.6] ************************************************************************

@embray

This comment has been minimized.

@rwst
Copy link
Contributor Author

rwst commented Apr 20, 2017

comment:6

The servers get it only after merge and a new Sage release. Download from github into your upstream directory.

@tscrim
Copy link
Collaborator

tscrim commented Apr 20, 2017

Changed branch from u/rws/upgrade_to_pynac_0_7_6 to u/tscrim/pynac_0_7_6-22838

@tscrim
Copy link
Collaborator

tscrim commented Apr 20, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Apr 20, 2017

Changed commit from 7d3fd60 to ca852a1

@tscrim
Copy link
Collaborator

tscrim commented Apr 20, 2017

comment:7

I did some fixes. The most important is the documentation for step was wrong since SR(0).step() == 1. I also changed a little nitpick with alignments. If my changes are good, then positive review.


New commits:

ca852a1Some reviewer tweaks.

@rwst
Copy link
Contributor Author

rwst commented Apr 20, 2017

comment:8

Thanks!

@vbraun
Copy link
Member

vbraun commented Apr 22, 2017

comment:9
sage -t --long src/sage/tests/gosper-sum.py
**********************************************************************
File "src/sage/tests/gosper-sum.py", line 133, in sage.tests.gosper-sum
Failed example:
    check((4*(1-n) * (n^2-2*n-1) / n^2 / (n+1)^2 / (n-2)^2 / (n-3)^2), n, 4, 10, 20)
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 509, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 872, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.tests.gosper-sum[53]>", line 1, in <module>
        check((Integer(4)*(Integer(1)-n) * (n**Integer(2)-Integer(2)*n-Integer(1)) / n**Integer(2) / (n+Integer(1))**Integer(2) / (n-Integer(2))**Integer(2) / (n-Integer(3))**Integer(2)), n, Integer(4), Integer(10), Integer(20))
      File "<doctest sage.tests.gosper-sum[18]>", line 4, in check
        s1 = ex.gosper_sum(var, val1, symb)
      File "sage/symbolic/expression.pyx", line 6714, in sage.symbolic.expression.Expression.gosper_sum (/Users/buildslave-sage/slave/sage_git/build/src/build/cythonized/sage/symbolic/expression.cpp:39839)
        x = g_gosper_sum_definite(self._gobj, s._gobj,
    RuntimeError: can't happen in coeff_to_ex
**********************************************************************
File "src/sage/tests/gosper-sum.py", line 134, in sage.tests.gosper-sum
Failed example:
    check(((n^4-14*n^2-24*n-9) * 2^n / n^2 / (n+1)^2 / (n+2)^2 / (n+3)^2), n, 1, 10, 20)
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 509, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 872, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.tests.gosper-sum[54]>", line 1, in <module>
        check(((n**Integer(4)-Integer(14)*n**Integer(2)-Integer(24)*n-Integer(9)) * Integer(2)**n / n**Integer(2) / (n+Integer(1))**Integer(2) / (n+Integer(2))**Integer(2) / (n+Integer(3))**Integer(2)), n, Integer(1), Integer(10), Integer(20))
      File "<doctest sage.tests.gosper-sum[18]>", line 4, in check
        s1 = ex.gosper_sum(var, val1, symb)
      File "sage/symbolic/expression.pyx", line 6714, in sage.symbolic.expression.Expression.gosper_sum (/Users/buildslave-sage/slave/sage_git/build/src/build/cythonized/sage/symbolic/expression.cpp:39839)
        x = g_gosper_sum_definite(self._gobj, s._gobj,
    RuntimeError: can't happen in coeff_to_ex
**********************************************************************
1 item had failures:
   2 of 101 in sage.tests.gosper-sum
    [100 tests, 2 failures, 23.48 s]

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

comment:10

This is conflicting with #22090. I'd rather if you hold back #22090 instead of this. Is it possible?

@tscrim
Copy link
Collaborator

tscrim commented Apr 23, 2017

comment:11

It seems like Volker has already merged #22090 into his develop branch. So I wouldn't touch #22090. Also, doesn't #22090 expose a regression in pynac?

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

comment:12

Replying to @tscrim:

Also, doesn't #22090 expose a regression in pynac?

Of course. But I would have liked to be not under time pressure with the fix.

@tscrim
Copy link
Collaborator

tscrim commented Apr 23, 2017

comment:13

You could mark those failing tests as # known bug for now.

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

comment:14

I can do that only in #22090 because only there the new file with the test case is introduced. But instead of a new release I'll add a patch here.

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

Changed branch from u/tscrim/pynac_0_7_6-22838 to u/rws/pynac_0_7_6-22838

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

New commits:

77ffff722838: last minute patch to Singular interface; fixes regression

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

Changed commit from ca852a1 to 77ffff7

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

New commits:

ca852a1Some reviewer tweaks.

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

Changed branch from u/rws/pynac_0_7_6-22838 to u/tscrim/pynac_0_7_6-22838

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

Changed commit from 77ffff7 to ca852a1

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

Changed branch from u/tscrim/pynac_0_7_6-22838 to u/rws/22838

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

Changed commit from ca852a1 to 6f8952a

@rwst
Copy link
Contributor Author

rwst commented Apr 23, 2017

New commits:

6f8952a22838: last minute patch to Singular interface; fixes regression

@tscrim
Copy link
Collaborator

tscrim commented Apr 23, 2017

comment:21

New patch fixes the regression. Thank you.

@rwst
Copy link
Contributor Author

rwst commented Apr 24, 2017

comment:22

Thanks again for the review.

@vbraun
Copy link
Member

vbraun commented Apr 27, 2017

Changed branch from u/rws/22838 to 6f8952a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants