-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute symbolic sums over the terms of their first (sum) argument #22915
Comments
comment:1
This first implementation follows the guidelines suggested by Ralf Stephan. It is probably highly perfectible :
Suggestions, criticisms, even lazzi are welcome as long as they are constructive... I'm not marking this as |
Branch: u/charpent/expand_sum |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
comment:3
Passes ptestl ==> |
This comment has been minimized.
This comment has been minimized.
comment:5
I would call this only if the expression contains sums, test it via e.g.:
Minor cosmetics would be to give ES a more descriptive name. Also you need spaces after commata, semicola, and around equal signs for convention. Finally please test if your documentation builds, the doctest spacing looks wrong. Oh and |
comment:7
Replying to @rwst:
Indeed. But isn't that more expensive than directly testing for the operator being sum (and recurse) ?
Will do (maybe : see below). But that's only an internal subfunction.
OK. (I'm probably the worst typist in the world...).
Indeed... But I'm beginning to have misgivings. "Distribute symbolic sums over sums" isn't lthe only case where this might be useful. We have also :
I'm starting to think that we may need a What do you think ? I'm setting this ticket to |
comment:8
Replying to @EmmanuelCharpentier:
I don't object. |
comment:9
Replying to @rwst:
Created #22937. I'll make an inital proposal there (not quite soon, alas...). I'll also post something on |
comment:10
For what it's worth, Maxima has
That's handled by the global simplifier, so it's all or nothing -- you can't expand one expression and not another. Dunno if that's an issue. Also, this action is purely formal -- if it's an infinite sum, the simplifier happily plows ahead without testing convergence. There is also a more general mechanism for distributing operators and functions over other operators and functions, via the symbol property DISTRIBUTE_OVER. This is used to distribute some functions over lists, matrices, and equations. The declaration has to be in Lisp, e.g. Anyway, hope that sheds some light. |
comment:11
Please take take ASAP of the apply/python3 issue introduced in #22937. |
comment:12
Dear Robert, Sorry, I didn't see your (quite enlightening) answer until right now (tywo weeks later). I've implemented (part of) what I want in #22937. But I'll consider comparing tgis implementation with changing the relevant properties on-the-fly to the same effect. Anyway, the present ticket is abandoned. I just forgot to close it. Replying to @robert-dodier:
|
This comment has been minimized.
This comment has been minimized.
comment:13
Replying to @fchapoton:
Indeed (see my answer on #22937). I forgot to close the present ticket, which I do now (setting its milestone to sage-duplicate/invalid/wontfix and giving it positive review).. |
comment:14
Closing tickets in the sage-duplicate/invalid/wontfix module with positive_review (i.e. someone has confirmed they should be closed). |
Motivation : see this sage-support post and Ralf Stephan's answer.
A similar enhancement could distribute symbolic products over the factors of their first (product) argument, but symbolic products are currently broken (see #22914).
This ticket has been abandoned in favor of #22937.
CC: @rwst
Component: symbolics
Branch/Commit: u/charpent/expand_sum @
19bd0be
Issue created by migration from https://trac.sagemath.org/ticket/22915
The text was updated successfully, but these errors were encountered: