Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctest fix for: wrong symbolic comparison of log #23224

Closed
fchapoton opened this issue Jun 12, 2017 · 12 comments
Closed

Doctest fix for: wrong symbolic comparison of log #23224

fchapoton opened this issue Jun 12, 2017 · 12 comments
Labels
c: symbolics p: major / 3 t: bug
Milestone
sage-8.2

Comments

@fchapoton
Copy link
Contributor

Namely

sage: bool(log(8)- 3*log(2))
True
sage: bool(log(8)==3*log(2))
False

compared to

sage: cmp(log(8),3*log(2))
0

And cmp should be going away in python3.

In principle Maxima should simplify log(8)-3*log(2) so it's a missing enhancement there. See pynac/pynac#258 for an enhancement that can provide another solution.

Depends on #23950
Depends on #18970

CC: @rwst @mforets

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 022656f

Reviewer: Marcelo Forets

Issue created by migration from https://trac.sagemath.org/ticket/23224
@fchapoton fchapoton added this to the sage-8.0 milestone Jun 12, 2017
@fchapoton

This comment has been minimized.

Sign in to view
@rwst
Copy link
Contributor

rwst commented Jun 12, 2017

comment:2

Factorization in GiNaC::log_eval, why not.

@rwst

This comment has been minimized.

Sign in to view
@rwst
Copy link
Contributor

rwst commented Oct 1, 2017

Dependencies: #23950

@rwst rwst modified the milestones: sage-8.0, sage-8.1 Oct 1, 2017
@rwst
Copy link
Contributor

rwst commented Oct 24, 2017

Branch: u/rws/23224

@rwst
Copy link
Contributor

rwst commented Oct 24, 2017

New commits:

b0486c818970: Log function and documentation revamp
022656f23224: doctests

@rwst
Copy link
Contributor

rwst commented Oct 24, 2017

Commit: 022656f

@rwst
Copy link
Contributor

rwst commented Oct 24, 2017

Changed dependencies from #23950 to #23950, #18970

@rwst
Copy link
Contributor

rwst commented Oct 24, 2017

Author: Ralf Stephan

@rwst rwst changed the title wrong symbolic comparison of log Doctest fix for: wrong symbolic comparison of log Oct 24, 2017
@mforets
Copy link
Mannequin

mforets mannequin commented Nov 28, 2017

Reviewer: Marcelo Forets

@mforets
Copy link
Mannequin

mforets mannequin commented Nov 28, 2017

comment:7

branch tested on SageMath version 8.1.rc2

@mforets mforets mannequin modified the milestones: sage-8.1, sage-8.2 Nov 28, 2017
@vbraun
Copy link
Member

vbraun commented Dec 11, 2017

Changed branch from u/rws/23224 to 022656f

@vbraun vbraun closed this as completed in 006eb8e Dec 11, 2017
@rwst rwst mentioned this issue Nov 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @rwst @fchapoton