Allow random sampling for unit testing

[roed314]

#16244 removed random sampling, but there are times when it would be nice to have. This ticket adds it back in, but optionally.

CC: @nthiery

Component: doctest framework

Author: David Roe

Branch/Commit: 5d4f93b

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/23724

[roed314]

Branch: u/roed/sampling_unittest

[roed314]

Commit: fb20bca

[roed314]

New commits:

fb20bca

Add the ability to randomly sample and easier access to cartesian products to sage_unittest

[sagetrac-git]

Changed commit from fb20bca to 5fc43c7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5fc43c7

Fix unmatche paren

[tscrim]

comment:4

What about also changing some_tuples for consistency?

[roed314]

comment:5

Changing how? Adding an optional keyword argument to use sampling instead? Something like

def some_tuples(elements, repeat, bound, sampling=False):
    from itertools import islice, product
    from random import sample
    P = product(elements, repeat=repeat)
    if sampling:
        try:
            return random.sample(P, bound)
        except ValueError:
            return P
    else:
        return islice(product(elements, repeat=repeat), bound)

[tscrim]

comment:6

I was thinking it would have the same idiom as the TestSuite with a max_samples=None argument, but basically, yes.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8542826

Unify implementatiion of some_tuples and tester.some_elements; improve implementation for large repeat

[sagetrac-git]

Changed commit from 5fc43c7 to 8542826

[saraedum]

Changed branch from u/roed/sampling_unittest to u/saraedum/sampling_unittest

[saraedum]

Reviewer: Julian Rüth

[saraedum]

Changed commit from 8542826 to 5d4f93b

[saraedum]

New commits:

5d4f93b

fix typo

[saraedum]

comment:10

I am confused about the patchbots errors. I first thought that was noise but it seems to be consistent for several patchbots.

[saraedum]

Work Issues: patchbot errors→positive review

[saraedum]

Changed work issues from patchbot errors→positive review to none

[vbraun]

Changed branch from u/saraedum/sampling_unittest to 5d4f93b