Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonnumeric integer expressions not handled by floor/ceil #24365

Closed
rwst opened this issue Dec 11, 2017 · 9 comments
Closed

Nonnumeric integer expressions not handled by floor/ceil #24365

rwst opened this issue Dec 11, 2017 · 9 comments
Labels
c: symbolics p: major / 3 t: bug
Milestone
sage-8.2

Comments

@rwst
Copy link
Contributor

rwst commented Dec 11, 2017

In #22079 floor/ceil gets a new implementation. Symbolic arguments are not checked with is_integer however so we get

sage: var('x',domain='integer')
x
sage: floor(x)
floor(x)
sage: ceil(x)
ceil(x)

Inserting that check (if not is_numeric) would immediately simplify a class of expressions.

Component: symbolics

Author: Ralf Stephan

Branch/Commit: fcd36b8

Reviewer: Bryan Gin-ge Chen

Issue created by migration from https://trac.sagemath.org/ticket/24365
@rwst rwst added this to the sage-8.2 milestone Dec 11, 2017
@rwst
Copy link
Contributor Author

rwst commented Feb 2, 2018

Branch: u/rws/nonnumeric_integer_expressions_not_handled_by_floor_ceil

@rwst
Copy link
Contributor Author

rwst commented Feb 2, 2018

Author: Ralf Stephan

@rwst
Copy link
Contributor Author

rwst commented Feb 2, 2018

New commits:

fcd36b824365: handle nonnumeric integer expressions in floor/ceil

@rwst
Copy link
Contributor Author

rwst commented Feb 2, 2018

Commit: fcd36b8

@rwst
Copy link
Contributor Author

rwst commented Mar 3, 2018

comment:3

Lots of doctest fails.

@rwst
Copy link
Contributor Author

rwst commented Mar 4, 2018

comment:4

Patchbot fails are all unrelated.

@bryangingechen
Copy link
Mannequin

bryangingechen mannequin commented Jul 28, 2018

Reviewer: Bryan Gin-ge Chen

@bryangingechen
Copy link
Mannequin

bryangingechen mannequin commented Jul 28, 2018

comment:5

This looks good to me.

@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/rws/nonnumeric_integer_expressions_not_handled_by_floor_ceil to fcd36b8

@vbraun vbraun closed this as completed in 453db04 Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
2 participants
@vbraun @rwst