Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gamma functions into their own file #24411

Closed
rwst opened this issue Dec 21, 2017 · 19 comments
Closed

Move gamma functions into their own file #24411

rwst opened this issue Dec 21, 2017 · 19 comments

Comments

@rwst
Copy link
Contributor

rwst commented Dec 21, 2017

gamma, log_gamma, gamma_inc, gamma_inc_lower, beta, psi are enough of the same kind to justify their own file. It eases pressure on the general other.py file and makes finding their documentation easier.

Component: symbolics

Author: Ralf Stephan

Branch: db535dc

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24411

@rwst rwst added this to the sage-8.2 milestone Dec 21, 2017
@rwst
Copy link
Contributor Author

rwst commented Dec 21, 2017

@rwst

This comment has been minimized.

@rwst
Copy link
Contributor Author

rwst commented Dec 21, 2017

New commits:

b49ea7624411: move gamma functions to gamma.py

@rwst
Copy link
Contributor Author

rwst commented Dec 21, 2017

Commit: b49ea76

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2018

Changed commit from b49ea76 to f87cf6c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 15, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

385bba6Merge branch 'develop' into t/24411/move_gamma_functions_into_their_own_file
f87cf6c24411: adapt to pynac-0.7.14

@tscrim
Copy link
Collaborator

tscrim commented Jan 15, 2018

comment:5

You will need to add deprecations saying the import locations have moved (lazy_import has an argument to do that). Also, you should add absolute_import to the new file's __future__ import(s). (Personally, I don't like the relative imports as it makes it less explicit, but I don't really care, so don't feel like you need to change/revert.)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

1bc73c424411: deprecation, imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 17, 2018

Changed commit from f87cf6c to 1bc73c4

@videlec
Copy link
Contributor

videlec commented Jan 17, 2018

comment:7

Author? If you don't field the field patchbot will never come.

@rwst
Copy link
Contributor Author

rwst commented Jan 18, 2018

Author: Ralf Stephan

@rwst
Copy link
Contributor Author

rwst commented Jan 29, 2018

comment:9

Tests fail.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

fc07c91Merge branch 'develop' into t/24411/move_gamma_functions_into_their_own_file
db535dc24411: more imports changed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 2, 2018

Changed commit from 1bc73c4 to db535dc

@tscrim
Copy link
Collaborator

tscrim commented Feb 2, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 2, 2018

comment:12

Patchbot is (morally) green and this is mostly just a big move ticket. Let's hope this doesn't conflict with anything.

@vbraun
Copy link
Member

vbraun commented Feb 3, 2018

Changed branch from u/rws/move_gamma_functions_into_their_own_file to db535dc

@fchapoton
Copy link
Contributor

comment:14

follow-up in #24719

@fchapoton
Copy link
Contributor

Changed commit from db535dc to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants