Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No evaluation with some functions #24604

Open
rwst opened this issue Jan 29, 2018 · 14 comments
Open

No evaluation with some functions #24604

rwst opened this issue Jan 29, 2018 · 14 comments

Comments

@rwst
Copy link
Contributor

rwst commented Jan 29, 2018

In a systematic search the following cases were found:

sage: arctan2(7,CDF(.92))
arctan2(7, 0.92)
sage: arctan2(7,CBF(.92))
arctan2(7, [0.9200000000000000 +/- 4.00e-17])
sage: elliptic_eu(7, CIF(1.7))
elliptic_eu(7, 1.7000000000000000?)
sage: elliptic_eu(7, complex(1.7))
elliptic_eu(7, (1.7+0j))
sage: jacobi_am(7, CIF(1.7))
jacobi_am(7, 1.7000000000000000?)
sage: jacobi_am(7, complex(1.7))
jacobi_am(7, (1.7+0j))

The systematic test will be committed with #24299.

Depends on #24630
Depends on #24668

Component: symbolics

Author: Ralf Stephan

Branch/Commit: u/rws/24604 @ f963efa

Issue created by migration from https://trac.sagemath.org/ticket/24604

@rwst rwst added this to the sage-8.2 milestone Jan 29, 2018
@rwst
Copy link
Contributor Author

rwst commented Jan 30, 2018

Commit: 0ab03cb

@rwst
Copy link
Contributor Author

rwst commented Jan 30, 2018

comment:1

The arctan cases were due to a case in py_atan2 not converting to the common P.


New commits:

0ab03cb24604: py_atan2 fixes

@rwst
Copy link
Contributor Author

rwst commented Jan 30, 2018

Branch: u/rws/24604

@rwst
Copy link
Contributor Author

rwst commented Jan 31, 2018

comment:2

The beta cases are fixed in Pynac-0.7.16.

@rwst
Copy link
Contributor Author

rwst commented Jan 31, 2018

Dependencies: pynac-0.7.16

@rwst
Copy link
Contributor Author

rwst commented Feb 1, 2018

Changed dependencies from pynac-0.7.16 to #24630, pynac-0.7.16

@rwst
Copy link
Contributor Author

rwst commented Feb 1, 2018

comment:3

For jacobi_am the eval function was enhanced. This revealed the conversion problem of #24630 which we now depend on.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 1, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

4045fd524604: fix jacobi_am eval

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 1, 2018

Changed commit from 0ab03cb to 4045fd5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 1, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

bf54f4c24604: fixes
f963efa24604: fixes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 1, 2018

Changed commit from 4045fd5 to f963efa

@rwst
Copy link
Contributor Author

rwst commented Feb 1, 2018

comment:6

Same applies to elliptic_eu.

@rwst
Copy link
Contributor Author

rwst commented Feb 19, 2018

Changed dependencies from #24630, pynac-0.7.16 to #24630, #24668

@rwst
Copy link
Contributor Author

rwst commented Feb 19, 2018

Author: Ralf Stephan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants