fflas and linbox broken with gcc 8.1.0

[videlec]

In file included from ../../linbox/matrix/densematrix/blas-matrix.h:54,
                 from ../../linbox/matrix/dense-matrix.h:79,
                 from ../../linbox/algorithms/rational-solver.h:43,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../linbox/matrix/densematrix/blas-transposed-matrix.h:74:8: error: too many template-parameter-lists
  class TransposedBlasMatrix< TransposedBlasMatrix< Matrix > > : public Matrix {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256.inl:186,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd.h:208,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_freduce.h:33,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas.h:104,
                 from ../../../../../../../../include/fflas-ffpack/ffpack/ffpack.h:47,
                 from ../../linbox/matrix/matrixdomain/blas-matrix-domain.h:45,
                 from ../../linbox/matrix/matrix-domain.h:68,
                 from ../../linbox/matrix/transpose-matrix.h:47,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.inl:34,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.h:1233,
                 from ../../linbox/matrix/densematrix/blas-matrix.h:55,
                 from ../../linbox/matrix/dense-matrix.h:79,
                 from ../../linbox/algorithms/rational-solver.h:43,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256_int64.inl:247:90: warning: 'const' attribute on function returning 'void' [-Wattributes]
  static INLINE CONST void unpacklohi(vect_t& l, vect_t& h, const vect_t a, const vect_t b) {
                                                                                          ^
In file included from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256.inl:187,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd.h:208,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_freduce.h:33,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas.h:104,
                 from ../../../../../../../../include/fflas-ffpack/ffpack/ffpack.h:47,
                 from ../../linbox/matrix/matrixdomain/blas-matrix-domain.h:45,
                 from ../../linbox/matrix/matrix-domain.h:68,
                 from ../../linbox/matrix/transpose-matrix.h:47,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.inl:34,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.h:1233,
                 from ../../linbox/matrix/densematrix/blas-matrix.h:55,
                 from ../../linbox/matrix/dense-matrix.h:79,
                 from ../../linbox/algorithms/rational-solver.h:43,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256_int32.inl:258:92: warning: 'const' attribute on function returning 'void' [-Wattributes]
  static INLINE CONST void unpacklohi(vect_t& s1, vect_t& s2, const vect_t a, const vect_t b) {
                                                                                            ^
In file included from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256.inl:188,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_simd.h:208,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas_freduce.h:33,
                 from ../../../../../../../../include/fflas-ffpack/fflas/fflas.h:104,
                 from ../../../../../../../../include/fflas-ffpack/ffpack/ffpack.h:47,
                 from ../../linbox/matrix/matrixdomain/blas-matrix-domain.h:45,
                 from ../../linbox/matrix/matrix-domain.h:68,
                 from ../../linbox/matrix/transpose-matrix.h:47,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.inl:34,
                 from ../../linbox/matrix/matrixdomain/matrix-domain.h:1233,
                 from ../../linbox/matrix/densematrix/blas-matrix.h:55,
                 from ../../linbox/matrix/dense-matrix.h:79,
                 from ../../linbox/algorithms/rational-solver.h:43,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../../../../../../../include/fflas-ffpack/fflas/fflas_simd/simd256_int16.inl:258:92: warning: 'const' attribute on function returning 'void' [-Wattributes]
  static INLINE CONST void unpacklohi(vect_t& s1, vect_t& s2, const vect_t a, const vect_t b) {

Upstream: Fixed upstream, but not in a stable release.

CC: @ClementPernet @slel

Component: packages: standard

Keywords: fflas, linbox, gcc-8

Author: Clement Pernet

Branch/Commit: cb566ea

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/25353

[videlec]

comment:1

Solve the const void in fflas with

$ sed -i s/INLINE\ CONST\ void/INLINE\ void/g $(find . -name "*inl")

[slel]

comment:3

See a discussion and a patch at
https://groups.google.com/forum/#!topic/sage-devel/NgzlZknrizg

[ClementPernet]

Branch: u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0

[ClementPernet]

Changed branch from u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0 to none

[ClementPernet]

comment:5

I agree with the proposed fixes for fflas given here and the simple removal of the double template proposed on sage-devel by fidelbc and Dario Asprone.
I have fixed both libraries upstream and add the corresponding patches to the branch for this ticket.

[ClementPernet]

Branch: u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0

[slel]

comment:7

Don't forget to set to "needs review" if this is ready for review.

---

New commits:

cb566ea

fixing gcc-8.1 compilation errors.

[slel]

Changed keywords from none to fflas, linbox, gcc-8

[slel]

Commit: cb566ea

[ClementPernet]

Author: Clement Pernet

[slel]

Upstream: Fixed upstream, but not in a stable release.

[saraedum]

Reviewer: Julian Rüth

[vbraun]

Changed branch from u/cpernet/fflas_and_linbox_broken_with_gcc_8_1_0 to cb566ea