Move cremona db to features

[timokau]

This continues the work in #20382 and #25835.

To test this I ran ./sage -t --optional=sage,gap_packages,database_cremona_ellcurve $( git diff --name-only HEAD~2 ).

Next steps in getting rid of is_package_installed etc.:

• sage.doctest.control: Replace use of sage.misc.package.list_packages #30746 sage.doctest.control: Replace use of sage.misc.package.list_packages
• Deprecate sage.misc.package functions standard_packages, optional_packages, experimental_packages #30747 Deprecate all of sage.misc.package except for PackageNotFoundError

CC: @tscrim @kiwifb @mkoeppe

Component: build

Author: Timo Kaufmann, Jeroen Demeyer, Antonio Rojas

Branch/Commit: 9c2dcb5

Reviewer: Julian Rüth, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/25825

[timokau]

comment:3

I just discovered #24718. This seems to be related/a duplicate. But that ticket seems to do some more unrelated stuff and probably needs a rebase. No clue why that is still "new".

[jdemeyer]

comment:4

In any case, I would rather have 1 ticket for each issue (1 for GAP, one for the Cremona database).

[timokau]

comment:5

Sure, I'll split it up.

[timokau]

New commits:

ca701d9

Replace gap package checks with features

[timokau]

Changed branch from u/gh-timokau/use-features to u/gh-timokau/cremona-db-features

[timokau]

Changed commit from c13f429 to ca701d9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1030350

Replace remona db checks with features

[sagetrac-git]

Changed commit from ca701d9 to 1030350

[timokau]

comment:8

Split to this and #25835.

[jdemeyer]

comment:9

As I mentioned on #24718: We should also use the database location discovered by the feature check instead of hardcoding it. In other words: there should be a single source for the database location.

[timokau]

Dependencies: #25309

[timokau]

comment:10

What do you mean by "discover"? It looks to me like the path to the database is just as hardcoded in the feature. Am I reading that wrong?

That should probably use the environment variable I introduced in #25309 though. So that'll have to be merged first.

[jdemeyer]

comment:11

Replying to @timokau:

It looks to me like the path to the database is just as hardcoded in the feature.

Yes, it's hardcoded in two different places which is bad design. There should be single source for it.

[timokau]

comment:12

I agree, I'll use the environment variable after #25309 is merged.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e738ff5

Replace remona db checks with features

[sagetrac-git]

Changed commit from 1030350 to e738ff5

[timokau]

comment:15

Alright I'm using the proper environment variables now.

[jdemeyer]

comment:51

The last 2 commits are not strictly needed, they are just cleaning stuff up. If a reviewer prefers to move that to a separate ticket, I'll do that.

[tscrim]

comment:52

I am just verifying the last two cleanup commits are good.

[antonio-rojas]

comment:53

Rebase needed

[antonio-rojas]

Changed branch from u/jdemeyer/cremona-db-features to u/arojas/cremona-db-features

[antonio-rojas]

comment:55

Let's please try to get this finally in

---

New commits:

6b7abb1	Merge branch 'develop' of git://git.sagemath.org/sage into t/25825/cremona-db-features
9c2dcb5	More flexible test for error message

[antonio-rojas]

Changed commit from 2cf92e6 to 9c2dcb5

[antonio-rojas]

Changed author from Timo Kaufmann, Jeroen Demeyer to Timo Kaufmann, Jeroen Demeyer, Antonio Rojas

[mkoeppe]

comment:56

Ticket description needs updating

[antonio-rojas]

comment:57

Replying to @mkoeppe:

Ticket description needs updating

Is the OptionalExtension bit still relevant? I'm not familiar with the recent changes in that area.

[mkoeppe]

comment:58

No, the use of OptionalExtension has been eliminated. See https://wiki.sagemath.org/ReleaseTours/sage-9.2#For_developers:_Changes_to_the_build_system_of_sagelib

[mkoeppe]

Changed reviewer from Julian Rüth to Julian Rüth, Matthias Koeppe

[vbraun]

Changed branch from u/arojas/cremona-db-features to 9c2dcb5