- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 601
clean generic_graph.py (part 7) - planarity #26658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
New commits:
|
Commit: |
Reviewer: Travis Scrimshaw |
comment:2
Another nitpick and while-we-are-at-it: we should not use contractions in error messages ( |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
I was not sure if |
comment:5
I don't think there is an official policy, but it just makes sense in terms of formality (e.g., you would not write it in a paper). Thank you for also fixing it. |
Changed branch from public/26658_generic_graph_part_7_planarity to |
Here we clean methods related to planarity:
is_planar
,is_circular_planar
,layout_planar
,is_drawn_free_of_edge_crossings
,genus
,crossing_number
,faces
,num_faces
,planar_dual
..edges
, or use.edges(sort=False)
Not done:
set_planar_positions
: it is written inside the method:This method is deprecated since Sage-4.4.1.alpha2. Please use instead
.layout`. However, there is no clear deprecation warning. We can either add a proper deprecation warning and remove it in 1 year, or simply remove it as it has been marked as deprecated for so many years... A specific ticket is needed anyway.CC: @tscrim @fchapoton
Component: graph theory
Author: David Coudert
Branch/Commit:
b79c678
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/26658
The text was updated successfully, but these errors were encountered: