spkg-configure.m4 for flint

[dimpase]

Flint on Sage is linked with NTL, and this can be checked by testing for presence of
fmpz_poly_get_ZZX there. So, this:

SAGE_SPKG_CONFIGURE([flint], [
    AC_CHECK_HEADER(flint/flint.h, [], [sage_spkg_install_flint=yes])
dnl fmpz_mat_is_hadamard appears in Flint 2.5.0
    AC_SEARCH_LIBS([fmpz_mat_is_hadamard], [flint], [], [sage_spkg_install_flint=yes])
    AC_SEARCH_LIBS([fmpz_poly_get_ZZX], [flint], [break], [sage_spkg_install_flint=yes])
])

CC: @embray

Component: build

Author: Dima Pasechnik

Branch/Commit: u/dimpase/packages/flintconfig @ 8fc4fb6

Issue created by migration from https://trac.sagemath.org/ticket/27264

[embray]

comment:1

Do you want to go ahead and add a branch? Obviously, it seems fine to me at first glance.

[dimpase]

comment:2

Yes, but need to do #27265 (NTL) first

[dimpase]

Dependencies: #27265

[dimpase]

Commit: 82772d7

[dimpase]

Branch: u/dimpase/packages/flintconfig

[dimpase]

Changed dependencies from #27265 to #27265, #27212

[dimpase]

Last 10 new commits:

af9ab90	deal with --with-ntl, proper version check
5e1a30b	spkg-configure for mpfr, adjustments for its dependees
18fbf7b	add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
50aebab	implement --with-mpfr=system/install
0fc433f	update for Sage 8.7.rc0, a typo fix
38427e1	spkg-configure for mpc, adjustments for its dependees
ec32471	Merge branch 'u/dimpase/packages/mpc-config' of trac.sagemath.org:sage into mpf
91f423f	rebase, deal with --with-mpc
33edfa8	Merge branch 'mpf' into flintconf - no spkg-configure yet
82772d7	spkg-configure for flint

[embray]

comment:5

Should we still look at NTL first, or maybe try testing with both this ticket and #27265 merged together?

[dimpase]

comment:6

Naturally, I am testing them all together...
(this branch has them all).

Actually, there is a lot of common boilerplate in spkg-configure.m4's for mpfr, mpc, ntl, and flint. But OK, perhaps this simplification can wait---depending upon how many more spkgs need --with-...= support.

[embray]

comment:7

I agree, I think that for now it will be simpler and easier to understand if we are somewhat repetitive. If, once we've made more progress, a clear pattern emerges then I can certainly collapse the repetitive bits into a macro.

[dimpase]

comment:8

This needs an extra test that flint was not built with --with-gc=... option, which results in a memory layout different from what Sage interface expects, and leads to crashes, e.g. in src/sage/libs/flint/fmpz_poly.pyx.

This option is on on some systems by default, e.g. on Gentoo...

[sagetrac-git]

Changed commit from 82772d7 to c1ac4f2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

24f17d5	testi for GC enabled
c1ac4f2	proper nesting of tests

[embray]

comment:10

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

[sagetrac-git]

Changed commit from c1ac4f2 to 0e0947d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0e0947d

typo in parameter

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

1353705	another missing then
58c9acd	spkg-configure for mpfr, adjustments for its dependees
ef60157	add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
1357bef	implement --with-mpfr=system/install
e7d04e7	spkg-configure for mpc, adjustments for its dependees
fb3aec7	rebase, deal with --with-mpc
30b85f7	spkg-configure for flint
e17167e	testi for GC enabled
d7f3747	proper nesting of tests
88209e0	typo in parameter

[sagetrac-git]

Changed commit from 0e0947d to 88209e0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a867838

typo

[sagetrac-git]

Changed commit from 88209e0 to a867838

[sagetrac-git]

Changed commit from a867838 to 8fc4fb6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ef5c200	add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
9aab721	implement --with-mpfr=system/install
0392e76	rebase, deal with --with-mpc
73ce2a9	spkg-configure for flint
37fa1a1	testi for GC enabled
4f6434c	proper nesting of tests
a672706	typo in parameter
013dfbe	typo
e698ffc	corrected rebase
8fc4fb6	add dependency checks, remove unneeded `-with` handling

[dimpase]

Changed dependencies from #27265, #27212 to #27822

[dimpase]

comment:15

rebased over #27822 branch, added deps checks, etc

[dimpase]

comment:16

should this be bundled with arb?

[dimpase]

comment:17

to be merged as a part of #27270

[dimpase]

Changed dependencies from #27822 to none