Update src/ext/doctest/python3-known-passing.txt

[jhpalmieri]

Update the list of files whose doctests should pass with Python 3.

Depends on #25680

Component: python3

Author: John Palmieri

Branch/Commit: fb4381f

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/27519

[jhpalmieri]

Branch: u/jhpalmieri/update-known-py3-tests

[jhpalmieri]

Commit: 930556e

[jhpalmieri]

comment:2

I'm also tempted to make this change:

diff --git a/Makefile b/Makefile
index cb1e291313..7628ad7855 100644
--- a/Makefile
+++ b/Makefile
@@ -143,7 +143,7 @@ fast-rebuild-clean: misc-clean bdist-clean
 
 TESTALL = ./sage -t --all
 PTESTALL = ./sage -t -p --all
-PTEST_PYTHON3 = cat src/ext/doctest/python3-known-passing.txt | xargs ./sage -t --long -p
+PTEST_PYTHON3 = sed '/^\#.*$$/d' src/ext/doctest/python3-known-passing.txt | xargs ./sage -t --long -p
 
 # Flags for ./sage -t --all.
 # By default, include all tests marked 'dochtml' -- see
diff --git a/src/ext/doctest/python3-known-passing.txt b/src/ext/doctest/python3-known-passing.txt
index 0b70f229f0..99412b844e 100644
--- a/src/ext/doctest/python3-known-passing.txt
+++ b/src/ext/doctest/python3-known-passing.txt
@@ -1,3 +1,7 @@
+# Each line starting with '#' is a comment.
+# Each other line should list a directory in which doctests are known
+# to pass with Python 3.
+#
 src/sage/algebras/
 src/sage/arith/
 src/sage/calculus/

Comments? Good idea or bad? Here or on another ticket?

---

New commits:

930556e

trac 27519: update python3-known-passing.txt

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fb4381f

trac 27519: update python3-known-passing.txt

[sagetrac-git]

Changed commit from 930556e to fb4381f

[jdemeyer]

comment:5

I would really like to focus our Python3 effort on Python 3.7 (#25680) first.

If it weren't for the previous ticket updating python3-known-passing.txt, #25680 would have been merged already. At some point, everything worked with 3.7 but because the tests are such a moving target, stuff got broken again.

For that reason, I'm personally -1 on this ticket.

[jhpalmieri]

comment:6

The file hasn't been modified in a month, and it is important to try to catch regressions. I think upgrading once per release is not too often. Did you never want to modify this file? What's your alternative?

What is left to be done on #25680, anyway?

[jdemeyer]

comment:7

Replying to @jhpalmieri:

Did you never want to modify this file? What's your alternative?

My suggestion is to first merge #25680.

[jdemeyer]

Dependencies: #25680

[jdemeyer]

Reviewer: Jeroen Demeyer

[vbraun]

Changed branch from u/jhpalmieri/update-known-py3-tests to fb4381f