Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault / memory corruption in OpenBLAS #27565

Closed
embray opened this issue Mar 29, 2019 · 16 comments
Closed

Fix segfault / memory corruption in OpenBLAS #27565

embray opened this issue Mar 29, 2019 · 16 comments

Comments

@embray
Copy link
Contributor

embray commented Mar 29, 2019

There is a bug in OpenBLAS already fixed upstream which I am encountering on Cygwin, though it could also affect Linux (in fact the original bug report was for Linux).

For Sage, this bug is causing a segfault on Cygwin when running

./sage -t --long src/sage/manifolds/differentiable/vectorfield.py

but it could happen arbitrarily anywhere that uses OpenBLAS and that happens to use threads (even without using OpenBLAS threads).

I have already confirmed that the upstream fix resolves the issue for me.

Upstream: Fixed upstream, but not in a stable release.

Component: packages: standard

Keywords: openblas

Author: Erik Bray

Branch: 4aa19b0

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/27565

@embray embray added this to the sage-8.8 milestone Mar 29, 2019
@embray
Copy link
Contributor Author

embray commented Mar 29, 2019

Commit: 9db4320

@embray
Copy link
Contributor Author

embray commented Mar 29, 2019

Branch: u/embray/ticket-27565

@embray
Copy link
Contributor Author

embray commented Mar 29, 2019

Author: Erik Bray

@kiwifb
Copy link
Member

kiwifb commented Mar 29, 2019

comment:2

There is no changes to openblas on this branch. Did you forget to commit?

@embray
Copy link
Contributor Author

embray commented Apr 1, 2019

comment:3

Strange. It looks like I did.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

3d0a86bTrac #27565: Add patch from upstream to fix segfaults.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 1, 2019

Changed commit from 9db4320 to 3d0a86b

@embray
Copy link
Contributor Author

embray commented Apr 1, 2019

comment:5

There it is. I was working on this on the train last week so who knows what could've interrupted me.

@kiwifb
Copy link
Member

kiwifb commented Apr 1, 2019

comment:6

Including a a patch merged upstream. I think it is safe.

@kiwifb
Copy link
Member

kiwifb commented Apr 1, 2019

Reviewer: François Bissey

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2019

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

e5873dcTrac #27565: Add patch from upstream to fix segfaults.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2019

Changed commit from 3d0a86b to e5873dc

@embray
Copy link
Contributor Author

embray commented Apr 3, 2019

comment:8

Rebased on 8.8.beta0 (not strictly necessary, but I wanted to anyways so that I could test the rest of 8.8.beta0 on Cygwin).

@embray
Copy link
Contributor Author

embray commented Apr 18, 2019

Changed commit from e5873dc to none

@embray
Copy link
Contributor Author

embray commented Apr 18, 2019

Changed branch from u/embray/ticket-27565 to 4aa19b0

@embray
Copy link
Contributor Author

embray commented Apr 18, 2019

comment:10

The branch on this didn't get updated for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants