sage.plot.plot3d.texture minor refactoring

[embray]

The module sage.plot.plot3d.texture defines a Texture_class class, and a Texture function that acts as its alternate constructor, along with an is_Texture function, à la the old scheme used elsewhere in Sage.

As discussed elsewhere (e.g. in #12824) the is_Texture function should be deprecated. The Texture function and Texture_class class can be merged into a single Texture class with use of a __classcall__ method.

CC: @egourgoulhon @paulmasson @slel @tscrim

Component: graphics

Keywords: texture

Author: Erik Bray

Branch/Commit: 604398e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27593

[embray]

Branch: u/embray/plot3d/texture-refactoring

[embray]

Author: Erik Bray

[embray]

comment:1

I do think the use of __classcall__ is a bit overkill here, since it's basically just doing some argument pre-processing that could probably just as well be done in the __init__. I thought maybe it would also cache some textures but apparently it doesn't even do that.

That said, this branch preserves the existing functionality, and I think in a better way than having a separate Texture_class and Texture factory function.

---

New commits:

23f043b

Trac #27593: Minor refactoring of Texture+Texture_class into a single Texture class

[embray]

Commit: 23f043b

[embray]

comment:2

Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).

[slel]

Changed keywords from none to texture

[embray]

comment:4

Ticket retargeted after milestone closed

[mkoeppe]

comment:5

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

[fchapoton]

Changed branch from u/embray/plot3d/texture-refactoring to public/ticket/27593

[fchapoton]

comment:6

rebased, refreshed

---

New commits:

d39f55e

Merge branch 'u/embray/plot3d/texture-refactoring' in 9.2.b8

[fchapoton]

Changed commit from 23f043b to d39f55e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

604398e

fix use of is_Texture in plot3d base

[sagetrac-git]

Changed commit from d39f55e to 604398e

[fchapoton]

comment:8

green bot please review

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:9

LGTM.

[embray]

comment:10

Thanks for rebasing.

[vbraun]

Changed branch from public/ticket/27593 to 604398e