matrix_from_columns() assertion failure

[jdemeyer]

In src/sage/matrix/matrix1.pyx, the matrix_from_columns() method has the following pieces:

        if not isinstance(columns, (list, tuple)):
            columns = list(columns)

        ...

        ncols = PyList_GET_SIZE(columns)

Note how PyList_GET_SIZE may be called on a tuple. This is invalid and causes assertion failures with Python 3.7.

Analogously for matrix_from_rows() and matrix_from_rows_and_columns().

CC: @kiwifb @slel

Component: linear algebra

Author: Jeroen Demeyer

Branch/Commit: 1a32690

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/27688

[jdemeyer]

Branch: u/jdemeyer/matrix_from_columns___assertion_failure

[jdemeyer]

Commit: f751bc4

[jdemeyer]

New commits:

f751bc4

Fix matrix_from_columns() assertion failure

[kiwifb]

comment:5

I'll test in the morning. Is the stuff in rings/number_field/totallyreal_rel.py supposed to be there?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1a32690

Fix matrix_from_columns() assertion failure

[sagetrac-git]

Changed commit from f751bc4 to 1a32690

[jdemeyer]

comment:7

Replying to @kiwifb:

Is the stuff in rings/number_field/totallyreal_rel.py supposed to be there?

No. I fixed that.

[kiwifb]

comment:8

I was half expecting to find further problems building the docs but it all went smoothly to the end :)

[kiwifb]

Reviewer: François Bissey

[vbraun]

Changed branch from u/jdemeyer/matrix_from_columns___assertion_failure to 1a32690