Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polymake: Add spkg-legacy-uninstall, use sdh scripts #27855

Closed
mkoeppe opened this issue May 21, 2019 · 9 comments
Closed

polymake: Add spkg-legacy-uninstall, use sdh scripts #27855

mkoeppe opened this issue May 21, 2019 · 9 comments
Labels
c: packages: experimental p: major / 3 t: enhancement
Milestone
sage-8.8

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 21, 2019

This is to make installation more robust (see #27763).

CC: @dimpase @sophiasage @jplab

Component: packages: experimental

Author: Matthias Koeppe

Branch/Commit: e436971

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27855
@mkoeppe mkoeppe added this to the sage-8.8 milestone May 21, 2019
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 21, 2019

Branch: u/mkoeppe/polymake__add_spkg_legacy_uninstall__use_sdh_scripts__destdir_install

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 21, 2019

New commits:

8f40c63Add build/pkgs/polymake/spkg-legacy-uninstall
e436971polymake: DESTDIR install, use sdh scripts

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 21, 2019

Commit: e436971

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 21, 2019

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title polymake: Add spkg-legacy-uninstall, use sdh scripts, DESTDIR install polymake: Add spkg-legacy-uninstall, use sdh scripts May 21, 2019
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 21, 2019

comment:4

The two-stage install via DESTDIR actually does not work, but nevertheless this branch is an improvement.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 23, 2019

comment:5

Needs review.

@dimpase
Copy link
Member

dimpase commented May 23, 2019

comment:6

looks good to me

@dimpase
Copy link
Member

dimpase commented May 23, 2019

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented May 25, 2019

Changed branch from u/mkoeppe/polymake__add_spkg_legacy_uninstall__use_sdh_scripts__destdir_install to e436971

@vbraun vbraun closed this as completed in 8a1c240 May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: experimental p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe