Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision of Laurent series is restricted to be positive #28239

Closed
soehms opened this issue Jul 23, 2019 · 10 comments
Closed

Precision of Laurent series is restricted to be positive #28239

soehms opened this issue Jul 23, 2019 · 10 comments

Comments

@soehms
Copy link
Member

soehms commented Jul 23, 2019

The problem occured in context with #4618 (see comment 32) and is explained by the following code:

sage: L.<x> = LaurentSeriesRing(QQ)
sage: q = x^2 + x^3
sage: q.add_bigoh(-1)
Traceback (most recent call last):
...
ValueError: prec (= -3) must be non-negative

CC: @tscrim

Component: algebra

Keywords: Laurent series precision days100

Author: Sebastian Oehms

Branch/Commit: 14878d5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28239

@soehms soehms added this to the sage-8.9 milestone Jul 23, 2019
@embray
Copy link
Contributor

embray commented Dec 30, 2019

comment:1

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-8.9, sage-9.1 Dec 30, 2019
@soehms
Copy link
Member Author

soehms commented Jan 12, 2020

@soehms
Copy link
Member Author

soehms commented Jan 12, 2020

Author: Sebastian Oehms

@soehms
Copy link
Member Author

soehms commented Jan 12, 2020

Commit: 9a35541

@soehms
Copy link
Member Author

soehms commented Jan 12, 2020

comment:3

Just changed one line of code.


New commits:

9a3554128239: initial version

@tscrim
Copy link
Collaborator

tscrim commented Jan 12, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 12, 2020

comment:4

Can we also add sage: (t^(-2)).add_bigoh(-2) and remove the full-stop/period at the end of the INPUT: line. Once done, you can set a positive review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2020

Changed commit from 9a35541 to 14878d5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 12, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

14878d528239: fix according to review

@vbraun
Copy link
Member

vbraun commented Jan 20, 2020

Changed branch from u/soehms/neg_prec_laurent_series_28239 to 14878d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants