Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DESTDIR support for libbraiding and libhomfly #28927

Closed
embray opened this issue Dec 30, 2019 · 7 comments
Closed

DESTDIR support for libbraiding and libhomfly #28927

embray opened this issue Dec 30, 2019 · 7 comments
Labels
c: build p: major / 3
Milestone
sage-9.1

Comments

@embray
Copy link
Contributor

embray commented Dec 30, 2019

These were made into standard packages in #25705, just a little after work began on #24024, so they were omitted from the list of packages on that ticket and were never handled properly.

Component: build

Keywords: libhomfly libbraiding destdir

Author: Erik Bray

Branch/Commit: accd016

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/28927
@embray embray added this to the sage-9.1 milestone Dec 30, 2019
@embray
Copy link
Contributor Author

embray commented Dec 30, 2019

Commit: accd016

@embray
Copy link
Contributor Author

embray commented Dec 30, 2019

Author: Erik Bray

@embray
Copy link
Contributor Author

embray commented Dec 30, 2019

New commits:

accd016Trac #28927: Add DESTDIR build support to the libbraiding and libhomfly SPKGs

@embray
Copy link
Contributor Author

embray commented Dec 30, 2019

Branch: u/embray/ticket-28927

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2020

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jan 4, 2020

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jan 9, 2020

Changed branch from u/embray/ticket-28927 to accd016

@vbraun vbraun closed this as completed in 2b596aa Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@embray @vbraun @tscrim