Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.doctest: Remove handling of sagenb #29940

Closed
mkoeppe opened this issue Jun 22, 2020 · 13 comments
Closed

sage.doctest: Remove handling of sagenb #29940

mkoeppe opened this issue Jun 22, 2020 · 13 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 22, 2020

Follow up from #28834.

See also #29754 and #29885.

CC: @fchapoton @jhpalmieri @kliem

Component: doctest framework

Author: Matthias Koeppe

Branch/Commit: da41966

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29940

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 22, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 22, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 22, 2020

Commit: ad00b40

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 22, 2020

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 22, 2020

New commits:

6bec225sage.doctest.forker.DocTestTask._run: Remove special support for sagenb
ad00b40sage.doctest, src/bin/sage-runtests: Remove handling of sagenb

@tscrim
Copy link
Collaborator

tscrim commented Jun 22, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 22, 2020

comment:3

This for loop is now redundant:

        for o in ("all",):
            if o in opt:
                raise ValueError("You cannot run gdb/valgrind on the whole sage%s library"%("" if o == "all" else "nb"))

and the error message is no longer needs the choice.
Other than that LGTM.

@tscrim

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Changed commit from ad00b40 to da41966

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 22, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

da41966src/sage/doctest/control.py: Simplify singleton loop

@tscrim
Copy link
Collaborator

tscrim commented Jun 23, 2020

comment:5

Thank you. LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 23, 2020

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 8, 2020

Changed branch from u/mkoeppe/sage_doctest__remove_handling_of_sagenb to da41966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants