Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make finance doctests ready for random seeds #29983

Closed
kliem opened this issue Jun 24, 2020 · 11 comments
Closed

Make finance doctests ready for random seeds #29983

kliem opened this issue Jun 24, 2020 · 11 comments
Labels
c: doctest framework p: major / 3 t: enhancement
Milestone
sage-9.4

Comments

@kliem
Copy link
Contributor

kliem commented Jun 24, 2020

This ticket makes

sage -t --long --random-seed=n src/sage/finance/

pass for different values n than just 0.

Depends on #29962

Component: doctest framework

Author: Jonathan Kliem

Branch/Commit: 72a435d

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/29983
@kliem kliem added this to the sage-9.2 milestone Jun 24, 2020
@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Branch: public/29983

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Commit: 0639ae0

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

New commits:

da1c6bestart from a "random" random seed for doctesting
b7b836dmake random seed reproducible
eedbe5edocument random_seed
998b1b9default random seed 0 for now
1d7b00edash instead of underscore for command line options
0639ae0make finance fuzz ready

@kliem
Copy link
Contributor Author

kliem commented Jun 24, 2020

Author: Jonathan Kliem

@kliem
Copy link
Contributor Author

kliem commented Jul 12, 2020

comment:2

Merge conflict.

I also need to go through it again and check I respected the design decision in #29935.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 13, 2021

comment:4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 1, 2021

Changed commit from 0639ae0 to 72a435d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 1, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

72a435dmake finance ready for fuzzing doctests

@slel
Copy link
Member

slel commented Jun 1, 2021

Reviewer: Samuel Lelièvre

@kliem
Copy link
Contributor Author

kliem commented Jun 1, 2021

comment:8

Thank you.

@vbraun
Copy link
Member

vbraun commented Jun 19, 2021

Changed branch from public/29983 to 72a435d

@vbraun vbraun closed this as completed in 0664307 Jun 19, 2021
@dimpase dimpase mentioned this issue Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: doctest framework p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
4 participants
@vbraun @slel @mkoeppe @kliem