-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sphinx to 3.1 #30001
Comments
Branch: u/arojas/update_sphinx_to_3_1 |
Commit: |
This comment has been minimized.
This comment has been minimized.
Author: Antonio Rojas |
comment:3
I'm checking whether this will also fix #30008 https://github.com/kliem/sage/pull/17/checks. |
comment:4
Compared to Sage 9.2.beta1 with Sphinx 3.0.4, the bulleted lists here look double-spaced. Do we need to modify some setting? |
comment:5
Replying to @jhpalmieri:
It turns out that this is a Sphinx issue: sphinx-doc/sphinx#7838. |
comment:6
And sphinx-doc/sphinx#7852 contains a good fix. Do we want to use vanilla Sphinx 3.1.1 for now, or wait until this is merged (perhaps in 3.1.2)? |
comment:7
The vertical spacing problem supposedly has been fixed in Sphinx 3.1.2, which has now been released. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Reviewer: *John Palmieri* |
comment:9
Thank you for taking care of the upgrade to 3.1.2. The spacing is indeed fixed, and it builds and passes tests for me. Documentation looks good at a quick glance, although I didn't look at it super carefully. |
Changed reviewer from *John Palmieri* to John Palmieri |
Changed branch from u/arojas/update_sphinx_to_3_1 to |
This breaks doc build again, the 'modules' dict values are now namedtuples instead of tuples.
CC: @timokau @kiwifb @jhpalmieri
Component: documentation
Author: Antonio Rojas
Branch/Commit:
c574f58
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/30001
The text was updated successfully, but these errors were encountered: