Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx to 3.1 #30001

Closed
antonio-rojas opened this issue Jun 27, 2020 · 16 comments
Closed

Update sphinx to 3.1 #30001

antonio-rojas opened this issue Jun 27, 2020 · 16 comments

Comments

@antonio-rojas
Copy link
Contributor

This breaks doc build again, the 'modules' dict values are now namedtuples instead of tuples.

CC: @timokau @kiwifb @jhpalmieri

Component: documentation

Author: Antonio Rojas

Branch/Commit: c574f58

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30001

@antonio-rojas antonio-rojas added this to the sage-9.2 milestone Jun 27, 2020
@antonio-rojas
Copy link
Contributor Author

Branch: u/arojas/update_sphinx_to_3_1

@antonio-rojas
Copy link
Contributor Author

Commit: 07d0dae

@antonio-rojas

This comment has been minimized.

@antonio-rojas
Copy link
Contributor Author

New commits:

c46c6e7Update sphinx to 3.1.1
07d0daeport 'modules' dict values from tuple to namedtuple

@antonio-rojas
Copy link
Contributor Author

Author: Antonio Rojas

@kliem
Copy link
Contributor

kliem commented Jun 29, 2020

comment:3

I'm checking whether this will also fix #30008

https://github.com/kliem/sage/pull/17/checks.

@jhpalmieri
Copy link
Member

comment:4

Compared to Sage 9.2.beta1 with Sphinx 3.0.4, the bulleted lists here look double-spaced. Do we need to modify some setting?

@jhpalmieri
Copy link
Member

comment:5

Replying to @jhpalmieri:

Compared to Sage 9.2.beta1 with Sphinx 3.0.4, the bulleted lists here look double-spaced. Do we need to modify some setting?

It turns out that this is a Sphinx issue: sphinx-doc/sphinx#7838.

@jhpalmieri
Copy link
Member

comment:6

And sphinx-doc/sphinx#7852 contains a good fix. Do we want to use vanilla Sphinx 3.1.1 for now, or wait until this is merged (perhaps in 3.1.2)?

@jhpalmieri
Copy link
Member

comment:7

The vertical spacing problem supposedly has been fixed in Sphinx 3.1.2, which has now been released.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 5, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

c574f58Update sphinx to 3.1.2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 5, 2020

Changed commit from 07d0dae to c574f58

@jhpalmieri
Copy link
Member

Reviewer: *John Palmieri*

@jhpalmieri
Copy link
Member

comment:9

Thank you for taking care of the upgrade to 3.1.2. The spacing is indeed fixed, and it builds and passes tests for me. Documentation looks good at a quick glance, although I didn't look at it super carefully.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 7, 2020

Changed reviewer from *John Palmieri* to John Palmieri

@vbraun
Copy link
Member

vbraun commented Jul 10, 2020

Changed branch from u/arojas/update_sphinx_to_3_1 to c574f58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants