Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

few easy internet doctests failures to fix #30632

Closed
seblabbe opened this issue Sep 22, 2020 · 9 comments
Closed

few easy internet doctests failures to fix #30632

seblabbe opened this issue Sep 22, 2020 · 9 comments

Comments

@seblabbe
Copy link
Contributor

With 9.2.beta13, the command

sage -tp --optional=sage,internet src/sage/misc/remote_file.py src/sage/databases/oeis.py src/sage/misc/package.py

gives

----------------------------------------------------------------------
sage -t --random-seed=0 src/sage/misc/remote_file.py  # 1 doctest failed
sage -t --random-seed=0 src/sage/databases/oeis.py  # 1 doctest failed
sage -t --random-seed=0 src/sage/misc/package.py  # 1 doctest failed
----------------------------------------------------------------------

Component: doctest coverage

Author: Sébastien Labbé

Branch/Commit: a442fa9

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/30632

@seblabbe seblabbe added this to the sage-9.2 milestone Sep 22, 2020
@seblabbe

This comment has been minimized.

@seblabbe
Copy link
Contributor Author

New commits:

a442fa930632: fixing internet doctest failures

@seblabbe
Copy link
Contributor Author

Author: Sébastien Labbé

@seblabbe
Copy link
Contributor Author

Branch: u/slabbe/30632

@seblabbe
Copy link
Contributor Author

Commit: a442fa9

@fchapoton
Copy link
Contributor

comment:3

ok, merci

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@slel
Copy link
Member

slel commented Sep 24, 2020

comment:4

The "not pypi" url could be changed to

-        sage: pypi = 'http://this.is.not.pypi.com/'
+        sage: pypi = 'http://not-pypi.example.com/'

but the existing solution works fine.

Merci Sébastien pour la branche, et Frédéric pour le feu vert.

@vbraun
Copy link
Member

vbraun commented Oct 5, 2020

Changed branch from u/slabbe/30632 to a442fa9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants