Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully fail if pip is not correctly installed #30712

Closed
tobiasdiez opened this issue Oct 3, 2020 · 3 comments
Closed

Gracefully fail if pip is not correctly installed #30712

tobiasdiez opened this issue Oct 3, 2020 · 3 comments
Labels
c: build p: minor / 4 t: enhancement
Milestone
sage-9.3

Comments

@tobiasdiez
Copy link
Contributor

If pip is not compiled successfully (as it's sadly the case for me right now), then pip_installed_packages throws an error instead of returning an empty list. This is fixed in this ticket.

CC: @mkoeppe

Component: build

Author: Tobias Diez

Branch/Commit: 8ab2285

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30712
@tobiasdiez tobiasdiez added this to the sage-9.2 milestone Oct 3, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 3, 2020

Reviewer: Matthias Koeppe

@tobiasdiez
Copy link
Contributor Author

comment:3

Thanks!

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@vbraun
Copy link
Member

vbraun commented Nov 7, 2020

Changed branch from public/build/hardenPip to 8ab2285

@vbraun vbraun closed this as completed Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tobiasdiez @mkoeppe