Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a few .all imports #30715

Closed
tobiasdiez opened this issue Oct 3, 2020 · 3 comments
Closed

Remove a few .all imports #30715

tobiasdiez opened this issue Oct 3, 2020 · 3 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.3

Comments

@tobiasdiez
Copy link
Contributor

Remove a few sage.xyz.all imports, so that the whole module xyz.all doesn't need to be loaded. That's not so important for the normal usage of sage, as there sage.all loads these other all imports as well. But this gets more important when part of sage is used as a library, and for the upcoming modularization.

Also two unused imports are removed.
The other changes are cosmetic (from ... import).

CC: @mkoeppe

Component: refactoring

Author: Tobias Diez

Branch/Commit: 875ba9e

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30715
@tobiasdiez tobiasdiez added this to the sage-9.2 milestone Oct 3, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 3, 2020

Reviewer: Matthias Koeppe

@tobiasdiez
Copy link
Contributor Author

comment:3

Thanks for the review!

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@vbraun
Copy link
Member

vbraun commented Nov 7, 2020

Changed branch from public/refactoring/allImports to 875ba9e

@vbraun vbraun closed this as completed Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tobiasdiez @mkoeppe