Restore deprecation warnings for imports from collections vs collections.abc

[slel]

Since #28012 we correctly import "collections
abstract base classes" from collections.abc.

This ticket is for the next step: unsilence the
corresponding deprecation warnings.

We postponed doing that since some of our dependencies
had not updated their imports yet.

See #28012 comment:23 for the discussion.

Depends on #32372

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: edc435e

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30768

[slel]

comment:1

The required change is:

diff --git a/src/sage/all.py b/src/sage/all.py
--- a/src/sage/all.py
+++ b/src/sage/all.py
@@ -306,10 +306,6 @@ warnings.filters.remove(('ignore', None, DeprecationWarning, None, 0))
 # Ignore all deprecations from IPython etc.
 warnings.filterwarnings('ignore', category=DeprecationWarning,
     module='.*(IPython|ipykernel|jupyter_client|jupyter_core|nbformat|notebook|ipywidgets|storemagic)')
-# Ignore collections.abc warnings, there are a lot of them but they are
-# harmless.
-warnings.filterwarnings('ignore', category=DeprecationWarning,
-    message='.*collections[.]abc.*')
 # However, be sure to keep OUR deprecation warnings
 warnings.filterwarnings('default', category=DeprecationWarning,
     message=r'[\s\S]*See https\?://trac.sagemath.org/[0-9]* for details.')

[fchapoton]

Commit: d4a64b3

[fchapoton]

comment:2

voila une branche

---

New commits:

d4a64b3

re-activate abc warnings

[fchapoton]

Branch: u/chapoton/30768

[fchapoton]

comment:3

urllib3 seems to be the main source of problems

EDIT:

but this seems to comes from urllib3 from inside requests

updating requests seem to fix a lot of them

requests should be upgraded in #31280

EDIT:

updating request apparently fixes all doctests

[mkoeppe]

Dependencies: #32372

[mkoeppe]

comment:4

The update of requests (with unvendored urllib3) is now split out to #32372

[mkoeppe]

Changed branch from u/chapoton/30768 to u/mkoeppe/30768

[mkoeppe]

Changed commit from d4a64b3 to 5ec278c

[mkoeppe]

comment:6

Rebased on top of #32372

---

New commits:

764b341	build/pkgs/chardet: New (unvendored from requests)
5b5e721	build/pkgs/idna: New (unvendored from requests)
649f5af	build/pkgs/urllib3: New (unvendored from requests)
b8cf517	build/pkgs/requests: Update to 2.26.0
b5dc185	build/pkgs/requests/dependencies: Add unvendored packages
9a05776	build/pkgs/urllib3: Update to 1.26.6
fbb7da9	build/pkgs/idna: Update to 3.2
81af3bf	build/pkgs/requests/checksums.ini: Add upstream_url
5ec278c	re-activate abc warnings

[mkoeppe]

Author: Frédéric Chapoton

[mkoeppe]

comment:8

Have you tracked down what versions of urllib3 / requests did the fix? We will need to put corresponding version lower bounds into build/pkgs/urllib3/install-requires.txt and build/pkgs/requests/install-requires.txt

[mkoeppe]

comment:9

According to https://docs.python-requests.org/en/master/community/updates/#id11, requests 2.19.0 did "Migrate to using collections.abc for 3.7 compatibility"; 2.16.0 did the unvendoring of urllib3 etc.
requests main branch sets the constraint urllib3>=1.21.1,<1.27 in https://github.com/psf/requests/blob/main/setup.py; the lower bound has not changed since 2.16.0

[sagetrac-git]

Changed commit from 5ec278c to edc435e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8c8a766	build/pkgs/charset_normalizer: New, use it instead of chardet as a dependency of requests
8cc62de	build/pkgs/chardet: Remove
eced0de	Merge #32372
edc435e	re-activate abc warnings

[slel]

comment:11

Is this ready for review?

[fchapoton]

comment:12

yes, but depending on #32372

[fchapoton]

comment:13

now this should be ready to go

[mkoeppe]

Reviewer: Matthias Koeppe

[vbraun]

Changed branch from u/mkoeppe/30768 to edc435e