Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate src/setup.py #30779

Closed
mkoeppe opened this issue Oct 16, 2020 · 8 comments
Closed

Duplicate src/setup.py #30779

mkoeppe opened this issue Oct 16, 2020 · 8 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 16, 2020

This is preparation for #30371 and #28925.

src/setup.py will be modified in #30371 for development installs.

build/pkgs/sagelib/src/setup.py will be modified in #28925 for namespace installs.

CC: @tobiasdiez

Component: build

Author: Matthias Koeppe

Branch/Commit: 4f56517

Reviewer: Tobias Diez

Issue created by migration from https://trac.sagemath.org/ticket/30779
@mkoeppe mkoeppe added this to the sage-9.3 milestone Oct 16, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2020

Branch: u/mkoeppe/duplicate_src_setup_py

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2020

New commits:

4f56517Duplicate src/setup.py

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 16, 2020

Commit: 4f56517

@tobiasdiez
Copy link
Contributor

Reviewer: Tobias Diez

@tobiasdiez
Copy link
Contributor

comment:3

LGTM

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 17, 2020

comment:4

Thanks.

@vbraun
Copy link
Member

vbraun commented Nov 1, 2020

Changed branch from u/mkoeppe/duplicate_src_setup_py to 4f56517

@vbraun vbraun closed this as completed in 257a9b5 Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @tobiasdiez @mkoeppe