Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.doctest.control: Do not fail if sage.libs.arb cannot be imported #31334

Closed
mkoeppe opened this issue Feb 4, 2021 · 7 comments
Closed

sage.doctest.control: Do not fail if sage.libs.arb cannot be imported #31334

mkoeppe opened this issue Feb 4, 2021 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 4, 2021

(extracted from #29865)

The dependency on sage.libs.arb was introduced in #30486.
We catch ImportError so that there are no failures in modularized
settings (#29865 - packages sagemath-objects, sagemath-categories).

CC: @kiwifb @dimpase @tobiasdiez

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 8e57f63

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/31334
@mkoeppe mkoeppe added this to the sage-9.3 milestone Feb 4, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 4, 2021

Branch: u/mkoeppe/sage_doctest_control__do_not_fail_if_sage_libs_arb_cannot_be_imported

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 4, 2021

Commit: 8e57f63

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 4, 2021

New commits:

8e57f63src/sage/doctest/control.py: Do not fail if sage.libs.arb cannot be imported

@kiwifb
Copy link
Member

kiwifb commented Feb 4, 2021

comment:3

This is trivially safe.

@kiwifb
Copy link
Member

kiwifb commented Feb 4, 2021

Reviewer: François Bissey

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 4, 2021

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 9, 2021

Changed branch from u/mkoeppe/sage_doctest_control__do_not_fail_if_sage_libs_arb_cannot_be_imported to 8e57f63

@vbraun vbraun closed this as completed in 0cc58fc Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@kiwifb @vbraun @mkoeppe