Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make empty RealSet false #31941

Closed
mkoeppe opened this issue Jun 9, 2021 · 8 comments
Closed

Make empty RealSet false #31941

mkoeppe opened this issue Jun 9, 2021 · 8 comments
Labels
c: geometry p: major / 3 t: bug
Milestone
sage-9.4

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 9, 2021

Currently we have:

sage: RealSet()
{}
sage: bool(_)
True

The fix has been split out from the branch of #24176

Depends on #31877

CC: @tscrim

Component: geometry

Author: Ralf Stephan

Branch/Commit: 53639be

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/31941
@mkoeppe mkoeppe added this to the sage-9.4 milestone Jun 9, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2021

Branch: u/mkoeppe/make_empty_realset_false

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2021

Author: Ralf Stephan

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2021

New commits:

d68a69fRealSet.__bool__: New (split out from #24171)
4b09685RealSet: Put it in a suitable subcategory of TopologicalSpaces()
46eed0eRealSet.ambient: Change to a normal method
53639beMerge #31877

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 9, 2021

Commit: 53639be

@tscrim
Copy link
Collaborator

tscrim commented Jun 9, 2021

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 9, 2021

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 29, 2021

Changed branch from u/mkoeppe/make_empty_realset_false to 53639be

@vbraun vbraun closed this as completed in af326a8 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe