Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctest in src/sage/rings/integer.pyx #32737

Closed
mkoeppe opened this issue Oct 21, 2021 · 10 comments
Closed

Fix doctest in src/sage/rings/integer.pyx #32737

mkoeppe opened this issue Oct 21, 2021 · 10 comments
Labels
c: basic arithmetic p: critical / 2 t: bug
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 21, 2021

Fixing a doctest rewritten in #32549

As reported in https://groups.google.com/g/sage-devel/c/5ML0VpeBamI/m/9p5DmPF2AQAJ

CC: @fchapoton @yyyyx4

Component: basic arithmetic

Author: Matthias Koeppe

Branch/Commit: ae29c47

Reviewer: Lorenz Panny

Issue created by migration from https://trac.sagemath.org/ticket/32737
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 21, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 21, 2021

Branch: u/mkoeppe/fix_doctest_in_src_sage_rings_integer_pyx

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 21, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 21, 2021

Commit: ae29c47

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 21, 2021

comment:2

Trying flush=True as suggested

New commits:

ae29c47src/sage/rings/integer.pyx: Flush output in doctest

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 21, 2021

comment:4

(untested, waiting for patchbot)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 21, 2021

comment:5

Green patchbot, please review

@yyyyx4
Copy link
Member

yyyyx4 commented Oct 22, 2021

Reviewer: Lorenz Panny

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 22, 2021

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 24, 2021

Changed branch from u/mkoeppe/fix_doctest_in_src_sage_rings_integer_pyx to ae29c47

@vbraun vbraun closed this as completed in b970bc9 Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: basic arithmetic p: critical / 2 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @yyyyx4